Replace the Close All control with the Undo control after the former is tapped. |
||||||||||||||||
Issue descriptionReplace the Close All control with the Undo control after the former is tapped. Revert Undo back to Close All after a user action
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Jan 25 2018
,
Jan 26 2018
,
Jan 27 2018
,
Mar 26 2018
,
Apr 5 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68 commit e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68 Author: edchin <edchin@chromium.org> Date: Fri Apr 06 21:03:43 2018 [ios] Undo Close All button in tab grid (part 1) This CL adds logic to show the Undo Close All button when the user closes all tabs. This CL does not implement the undo action. A followup CL will add more egtests, ensuring that undo is not available on incognito mode. Bug: 804566 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id97cb4bc3c5ad92ad622206d123a2fc37023048b Reviewed-on: https://chromium-review.googlesource.com/998333 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548925} [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.h [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.mm [modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Apr 10 2018
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
,
Apr 27 2018
,
May 8 2018
(+mardini) Thanks for wiring this up! It's a shame that the thumbnails aren't restored. How difficult is that to do as extra polish (I don't think it's blocking)?
,
May 8 2018
+1 regarding restoring thumbnails. I also noticed that sometimes I lose all my thumbnails. I'm not sure whether this is post-crash or post upgrade. |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018