New issue
Advanced search Search tips

Issue 804566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 804561

Blocking:
issue 804567



Sign in to add a comment

Replace the Close All control with the Undo control after the former is tapped.

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Replace the Close All control with the Undo control after the former is tapped.

Revert Undo back to Close All after a user action
 

Comment 1 by marq@chromium.org, Jan 23 2018

Description: Show this description

Comment 2 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: S-Undo-Close-All-Tabs

Comment 4 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 5 by marq@chromium.org, Jan 23 2018

Blockedon: 804561

Comment 6 by marq@chromium.org, Jan 23 2018

Blocking: 804567

Comment 7 by marq@chromium.org, Jan 23 2018

Labels: Q2

Comment 8 by marq@chromium.org, Jan 25 2018

Labels: -Q2 Q1

Comment 9 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: ----
Labels: Q2

Comment 11 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 13 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68

commit e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68
Author: edchin <edchin@chromium.org>
Date: Fri Apr 06 21:03:43 2018

[ios] Undo Close All button in tab grid (part 1)

This CL adds logic to show the Undo Close All button when the user
closes all tabs.
This CL does not implement the undo action.

A followup CL will add more egtests, ensuring that undo is not
available on incognito mode.

Bug:  804566 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id97cb4bc3c5ad92ad622206d123a2fc37023048b
Reviewed-on: https://chromium-review.googlesource.com/998333
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548925}
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.h
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.mm
[modify] https://crrev.com/e82cb4b94d57fb3a8f4659eff1bc54aa3cfc1d68/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Project Member

Comment 15 by sheriffbot@chromium.org, Apr 10 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Status: Fixed (was: Assigned)
Cc: mard...@chromium.org
(+mardini)

Thanks for wiring this up!

It's a shame that the thumbnails aren't restored. How difficult is that to do as extra polish (I don't think it's blocking)? 
+1 regarding restoring thumbnails. I also noticed that sometimes I lose all my thumbnails. I'm not sure whether this is post-crash or post upgrade. 

Sign in to add a comment