New issue
Advanced search Search tips

Issue 804560 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Update EarlGrey tests to support closing a tab.

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Update EarlGrey tests to support closing a tab.

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Close-One-Tab

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804498

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 7 by cmasso@google.com, Feb 20 2018

Blockedon: -804498
NextAction: 2018-03-14
Status: Started (was: Assigned)
A full integration close test is more useful than a showcase test, so I'm updating the title. 

FYI, the first part of updating Showcase was already completed while designing the GridViewControllerDelegate. 
Summary: Update EarlGrey tests to support closing a tab. (was: Update Showcase and Showcase EarlGrey tests to support closing a tab.)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a749c1d805039e6d0734f6757f7bc824dbd6f032

commit a749c1d805039e6d0734f6757f7bc824dbd6f032
Author: edchin <edchin@chromium.org>
Date: Thu Mar 08 23:19:57 2018

[ios] Add close cell egtest in tab grid

Bug:  804560 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8a7f1779aff808edddc525110c8900cbd9fd8b8a
Reviewed-on: https://chromium-review.googlesource.com/955345
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541925}
[modify] https://crrev.com/a749c1d805039e6d0734f6757f7bc824dbd6f032/ios/chrome/browser/ui/tab_grid/grid_cell.h
[modify] https://crrev.com/a749c1d805039e6d0734f6757f7bc824dbd6f032/ios/chrome/browser/ui/tab_grid/grid_cell.mm
[modify] https://crrev.com/a749c1d805039e6d0734f6757f7bc824dbd6f032/ios/chrome/browser/ui/tab_grid/grid_constants.h
[modify] https://crrev.com/a749c1d805039e6d0734f6757f7bc824dbd6f032/ios/chrome/browser/ui/tab_grid/grid_constants.mm
[modify] https://crrev.com/a749c1d805039e6d0734f6757f7bc824dbd6f032/ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm

Description: Show this description
Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-14

Comment 14 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment