New issue
Advanced search Search tips

Issue 804559 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804499



Sign in to add a comment

Disable the Done and Close All controls if there are no tabs.

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Disable the Done and Close All controls if there are no tabs.
 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Close-One-Tab

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804499

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: edchin@chromium.org
Status: Assigned (was: Available)
NextAction: 2018-03-14
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73fc9d2eab68af2239771e1dba8fe655ce9e3590

commit 73fc9d2eab68af2239771e1dba8fe655ce9e3590
Author: edchin <edchin@chromium.org>
Date: Thu Mar 08 19:16:21 2018

[ios] Disable buttons when last tab is closed

Bug:  804559 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6af3cfb03402cb9099902f87abe5ebf0948d9ec0
Reviewed-on: https://chromium-review.googlesource.com/955344
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541859}
[modify] https://crrev.com/73fc9d2eab68af2239771e1dba8fe655ce9e3590/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/73fc9d2eab68af2239771e1dba8fe655ce9e3590/ios/chrome/browser/ui/tab_grid/grid_view_controller.h
[modify] https://crrev.com/73fc9d2eab68af2239771e1dba8fe655ce9e3590/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm
[modify] https://crrev.com/73fc9d2eab68af2239771e1dba8fe655ce9e3590/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Comment 9 by edchin@chromium.org, Mar 13 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-14

Comment 11 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment