New issue
Advanced search Search tips

Issue 804558 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804557



Sign in to add a comment

Animate the appearance of the empty state prompt as the last tab closes

Project Member Reported by marq@chromium.org, Jan 23 2018

Issue description

Animate the appearance of the empty state prompt as the last tab closes
 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Close-One-Tab

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804557

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Status: Assigned (was: Available)

Comment 7 by marq@chromium.org, Mar 15 2018

NextAction: 2018-03-28

Comment 8 by marq@chromium.org, Mar 15 2018

Owner: edchin@chromium.org
Ed, punting this to you if that's OK.

Comment 9 by edchin@chromium.org, Mar 16 2018

Fantastic! I love animations, especially since I learned some cool techniques from reviewing your CLs. 
Do we have specs or mocks or descriptions of these animations?
Cc: marq@chromium.org
Status: Started (was: Assigned)
CL in-flight.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8520be330f34fc964c4d73077356e1ab9f3af5

commit 9d8520be330f34fc964c4d73077356e1ab9f3af5
Author: edchin <edchin@chromium.org>
Date: Thu Mar 22 14:40:19 2018

[ios] Animate tab grid empty state when closing last tab

This CL animates the appearance of the empty state prompt as the last
tab closes. The animation scales and fades in.

Bug:  804558 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1449560d6be676030048e11cf32db21123c37e5f
Reviewed-on: https://chromium-review.googlesource.com/974576
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545070}
[modify] https://crrev.com/9d8520be330f34fc964c4d73077356e1ab9f3af5/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm

Status: Fixed (was: Started)
Beautiful animation~~ looking so good. =)
The NextAction date has arrived: 2018-03-28

Sign in to add a comment