Issue metadata
Sign in to add a comment
|
Animate the appearance of the empty state prompt as the last tab closes |
||||||||||||||||||||||
Issue descriptionAnimate the appearance of the empty state prompt as the last tab closes
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Mar 15 2018
,
Mar 15 2018
Ed, punting this to you if that's OK.
,
Mar 16 2018
Fantastic! I love animations, especially since I learned some cool techniques from reviewing your CLs.
,
Mar 19 2018
Do we have specs or mocks or descriptions of these animations?
,
Mar 19 2018
,
Mar 22 2018
,
Mar 22 2018
CL in-flight.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d8520be330f34fc964c4d73077356e1ab9f3af5 commit 9d8520be330f34fc964c4d73077356e1ab9f3af5 Author: edchin <edchin@chromium.org> Date: Thu Mar 22 14:40:19 2018 [ios] Animate tab grid empty state when closing last tab This CL animates the appearance of the empty state prompt as the last tab closes. The animation scales and fades in. Bug: 804558 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1449560d6be676030048e11cf32db21123c37e5f Reviewed-on: https://chromium-review.googlesource.com/974576 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545070} [modify] https://crrev.com/9d8520be330f34fc964c4d73077356e1ab9f3af5/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
,
Mar 23 2018
Beautiful animation~~ looking so good. =)
,
Mar 28 2018
The NextAction date has arrived: 2018-03-28 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)