Issue metadata
Sign in to add a comment
|
Build the empty state prompt |
||||||||||||||||||||||
Issue descriptionBuild the empty state prompt for when there are no open tabs in the grid.
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Mar 7 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc724182d056a22d5b3869bcbb98828394f4af8d commit cc724182d056a22d5b3869bcbb98828394f4af8d Author: edchin <edchin@chromium.org> Date: Thu Mar 08 17:15:06 2018 [ios] Grid empty states This CL builds the basic logic and setup of the empty states in the regular and incognito grids. A future CL ( crbug.com/818198 ) will create a constants file and consolidate/organize numbers as needed. This CL leaves raw numbers in their place to minimize lookups while tweaking. New raw strings will be internationalized through the process. Bug: 804557 , 804573 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I546e88e195e1273bc34c2f2e5d8c4c2f48930263 Reviewed-on: https://chromium-review.googlesource.com/954714 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541816} [modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/grid_view_controller.h [modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm [modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 13 2018
,
Mar 14 2018
The NextAction date has arrived: 2018-03-14
,
Mar 14 2018
,
Mar 16 2018
Re-opening this because it should not have closed without: 1) Slightly different configuration/alignment for regular width size class 2) Eg tests Working on these now, and should still be able to finish before end of Q1.
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40a0872496ba62708bf57844114fb7222ee61183 commit 40a0872496ba62708bf57844114fb7222ee61183 Author: edchin <edchin@chromium.org> Date: Mon Mar 19 18:41:10 2018 [ios] Extract empty state from TabGridViewController This CL pulls a non-trivial amount of code out of TabGridViewController and encapsulates it in a separate UIView subclass. This CL also changes the layout based on orientation for the empty state. Bug: 804557 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic1f03445b014a331bdf383e999b522fcbe1b3143 Reviewed-on: https://chromium-review.googlesource.com/967731 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544078} [modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h [modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm [add] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_empty_state_view.h [add] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_empty_state_view.mm [modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 21 2018
Remaining CL to close this is an egtest update. This CL is in-flight.
,
Mar 21 2018
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/441a33587a52881e58817018d35f9053de062b9e commit 441a33587a52881e58817018d35f9053de062b9e Author: edchin <edchin@chromium.org> Date: Wed Mar 21 08:12:24 2018 [ios] Egtests for regular grid empty state Bug: 804557 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I78bd8b762afa23c27101afba9d37da85958dd582 Reviewed-on: https://chromium-review.googlesource.com/972189 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544654} [modify] https://crrev.com/441a33587a52881e58817018d35f9053de062b9e/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h [modify] https://crrev.com/441a33587a52881e58817018d35f9053de062b9e/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm [modify] https://crrev.com/441a33587a52881e58817018d35f9053de062b9e/ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm [modify] https://crrev.com/441a33587a52881e58817018d35f9053de062b9e/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h [modify] https://crrev.com/441a33587a52881e58817018d35f9053de062b9e/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 28 2018
The NextAction date has arrived: 2018-03-28 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)