New issue
Advanced search Search tips

Issue 804557 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804496

Blocking:
issue 804558



Sign in to add a comment

Build the empty state prompt

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Build the empty state prompt for when there are no open tabs in the grid.
 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Close-One-Tab

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804496

Comment 5 by marq@chromium.org, Jan 23 2018

Blocking: 804558

Comment 6 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 7 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: edchin@chromium.org
Status: Assigned (was: Available)
NextAction: 2018-03-14
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc724182d056a22d5b3869bcbb98828394f4af8d

commit cc724182d056a22d5b3869bcbb98828394f4af8d
Author: edchin <edchin@chromium.org>
Date: Thu Mar 08 17:15:06 2018

[ios] Grid empty states

This CL builds the basic logic and setup of the empty
states in the regular and incognito grids.

A future CL ( crbug.com/818198 ) will create a constants file
and consolidate/organize numbers as needed. This CL leaves
raw numbers in their place to minimize lookups while tweaking.

New raw strings will be internationalized through the process.

Bug:  804557 ,  804573 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I546e88e195e1273bc34c2f2e5d8c4c2f48930263
Reviewed-on: https://chromium-review.googlesource.com/954714
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541816}
[modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/grid_view_controller.h
[modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm
[modify] https://crrev.com/cc724182d056a22d5b3869bcbb98828394f4af8d/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-14

Comment 12 by cmasso@google.com, Mar 14 2018

NextAction: ----
NextAction: 2018-03-28
Status: Started (was: Fixed)
Re-opening this because it should not have closed without:
1) Slightly different configuration/alignment for regular width size class
2) Eg tests
Working on these now, and should still be able to finish before end of Q1. 
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40a0872496ba62708bf57844114fb7222ee61183

commit 40a0872496ba62708bf57844114fb7222ee61183
Author: edchin <edchin@chromium.org>
Date: Mon Mar 19 18:41:10 2018

[ios] Extract empty state from TabGridViewController

This CL pulls a non-trivial amount of code out of TabGridViewController
and encapsulates it in a separate UIView subclass.
This CL also changes the layout based on orientation for the empty
state.

Bug:  804557 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic1f03445b014a331bdf383e999b522fcbe1b3143
Reviewed-on: https://chromium-review.googlesource.com/967731
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544078}
[modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h
[modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm
[add] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_empty_state_view.h
[add] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_empty_state_view.mm
[modify] https://crrev.com/40a0872496ba62708bf57844114fb7222ee61183/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Remaining CL to close this is an egtest update. This CL is in-flight. 
Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-28

Sign in to add a comment