New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804554 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

OOPIF: Continuous resizing of content while scrolling

Project Member Reported by fsamuel@google.com, Jan 22 2018

Issue description

The size provided in ResizeParams to an OOPIF's RenderWidget is in DIP (device independent pixels) and is a function of the scroll position of the page because it uses ScaleToEnclosingRect. This can cause scrollbars to show up and disappear and causes blink to churn through unnecessary relayout eating up battery while scrolling.

The size of an OOPIF should be stable as scrolling happens.
 

Comment 1 by creis@chromium.org, Jan 23 2018

Cc: wjmaclean@chromium.org lfg@chromium.org
Components: Internals>Compositing>Scroll
Labels: -Pri-3 M-66 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Owner: kenrb@chromium.org
Status: Assigned (was: Untriaged)
Thanks for filing!  Ken, can you help triage this to find an owner?

Comment 2 by fsamuel@google.com, Jan 23 2018

I should add that this only happens on high DPI.

Comment 3 by creis@chromium.org, Feb 5 2018

Friendly ping.  Do we have a lead on how to fix, or anyone who may be able to help?

Ken/Fady: Can you also clarify whether there's a functional problem due to this bug, or if it's mainly a performance issue?
Components: -Internals>Compositing>Scroll
Feel free to re-add Component if the more specific is helpful later.

Comment 5 by kenrb@chromium.org, Feb 13 2018

Fady: To clarify, does this mean that the main frame is scrolling, and the OOPIF is getting continuous resize messages because of rounding changes in the frame rect size in the parent's layout?

Do you know how this doesn't happen for local frames?
Cc: fsam...@chromium.org
Labels: ReleaseBlock-Beta
+fsamuel@

Comment 7 by piman@chromium.org, Mar 2 2018

GPU triage: ping, what is the next step here?
Status: Fixed (was: Assigned)
Ohh I actually think I fixed this one a while ago.

https://chromium-review.googlesource.com/c/chromium/src/+/891663

The physical backing size is now a function of the "local frame size". The frame rect is no longer used. I'm marking this as FIXED. Yaay!
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.
Is there any merge need to M66 or M65? Is yes, pls request a merge otherwise remove "Merge-TBD" label. Thank you.
I don't think there is anything further to do. The fix is on the 66 branch, and this isn't high enough priority to warrant a merge to 65.
Labels: -Merge-TBD
Removing "Merge-TBD" label per comment #11. Thank you.

Sign in to add a comment