New issue
Advanced search Search tips

Issue 804553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804551



Sign in to add a comment

Add the correct animation behavior when closing a single tab

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Add the correct animation behavior when closing a single tab

- Animation on closing tab
- Animation on moving tabs

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-Close-One-Tab

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: medium

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804551

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Status: Assigned (was: Available)

Comment 7 by marq@chromium.org, Mar 15 2018

NextAction: 2018-03-28

Comment 8 by marq@chromium.org, Mar 15 2018

Cc: edchin@chromium.org
Labels: -medium small
Changing scope here to only include the delete tab animation. Moving the tab motion animation to the UI polish story.

Comment 9 by marq@chromium.org, Mar 15 2018

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f49290e8b52a322ca5a881359ea9360dc22f190c

commit f49290e8b52a322ca5a881359ea9360dc22f190c
Author: Mark Cogan <marq@google.com>
Date: Thu Mar 15 16:14:44 2018

[iOS] Animate tab grid cell deletion.

This CL customizes the deletion animation for tab grid cells via the
standard UICollectionViewLayout APIs.

Animation is done by adjusting the final layout attributes of the cell
in -finalLayoutAttributesForDisappearingItemAtIndexPath:. Because cells
may disappear for non-deleting reasons, the layout also needs to track
which cells are being deleted during each update cycle.

Bug:  804553 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8566a5aff832ac8844d2d89639599b1b2372a27d
Reviewed-on: https://chromium-review.googlesource.com/964223
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543389}
[modify] https://crrev.com/f49290e8b52a322ca5a881359ea9360dc22f190c/ios/chrome/browser/ui/tab_grid/grid_layout.mm

Comment 11 by marq@chromium.org, Mar 15 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-28

Sign in to add a comment