Web Locks API: Implement Service Worker test |
|||||||
Issue descriptionExisting tests target page, frame, and worker. The API would be exposed to Service Workers as well. We should have: * [x] idlharness tests in SW context * [x] basic functionality tests * [x] verification of clientIDs
,
Jan 29 2018
,
Mar 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/204d79fe950f5db610930cbeeb88cb4b0fb6b2c2 commit 204d79fe950f5db610930cbeeb88cb4b0fb6b2c2 Author: Joshua Bell <jsbell@chromium.org> Date: Sat Mar 03 00:26:30 2018 Web Locks API: Origin Trial Worker/ServiceWorker tests Ensure coverage for these cases: * API exposure in a Dedicated Worker, inheriting the OT token from the page. * API exposure in a Service Worker, OT token served via PHP header. * API exposure in a Service Worker, no OT token. It ensures the feature is not available in the virtual test suite for origin trials that disables experimental features, and is skipped otherwise. Also, add a basic Service Worker interface test with the other locks tests as well. Bug: 161072 , 804548 Change-Id: I2ec5ae5c7c0a5a7e72978c08e06368cf760eb92e Reviewed-on: https://chromium-review.googlesource.com/944787 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#540697} [add] https://crrev.com/204d79fe950f5db610930cbeeb88cb4b0fb6b2c2/third_party/WebKit/LayoutTests/http/tests/locks/interfaces-serviceworker.html [rename] https://crrev.com/204d79fe950f5db610930cbeeb88cb4b0fb6b2c2/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/README.md [add] https://crrev.com/204d79fe950f5db610930cbeeb88cb4b0fb6b2c2/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/weblocksapi-origin-trial-interfaces-serviceworker-disabled.js [add] https://crrev.com/204d79fe950f5db610930cbeeb88cb4b0fb6b2c2/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/weblocksapi-origin-trial-interfaces-serviceworker-enabled.php [add] https://crrev.com/204d79fe950f5db610930cbeeb88cb4b0fb6b2c2/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/weblocksapi-origin-trial-interfaces-worker.js [modify] https://crrev.com/204d79fe950f5db610930cbeeb88cb4b0fb6b2c2/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/weblocksapi-origin-trial-interfaces.html
,
Mar 3 2018
,
Jun 1 2018
,
Jun 1 2018
Should go ahead and add a test that demonstrates issue 810117 and then we can close this issue.
,
Jun 28 2018
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eeca82f01b5f53ebcc09076bcf14a3cb6bf5a86d commit eeca82f01b5f53ebcc09076bcf14a3cb6bf5a86d Author: Joshua Bell <jsbell@chromium.org> Date: Fri Jun 29 00:54:57 2018 Web Locks API: Test for clientId match with Service Workers The Service Workers API provides clientIds for FetchEvents and the clients API. The Web Locks API provides clientIds for the query() API. These should match for a given client (e.g. a controlled iframe holding a lock and making a fetch) - add a test to verify that this is the case. (This currently fails in Chrome since clientIds are minted separately for Service Workers and Web Locks.) Bug: 804548 , 810117 Change-Id: I3b56e52a203dd89b9070d804d92aaada0176b8ed Reviewed-on: https://chromium-review.googlesource.com/1117888 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#571347} [add] https://crrev.com/eeca82f01b5f53ebcc09076bcf14a3cb6bf5a86d/third_party/WebKit/LayoutTests/http/tests/locks/clientids-expected.txt [add] https://crrev.com/eeca82f01b5f53ebcc09076bcf14a3cb6bf5a86d/third_party/WebKit/LayoutTests/http/tests/locks/clientids.html [add] https://crrev.com/eeca82f01b5f53ebcc09076bcf14a3cb6bf5a86d/third_party/WebKit/LayoutTests/http/tests/locks/resources/service-worker.js [add] https://crrev.com/eeca82f01b5f53ebcc09076bcf14a3cb6bf5a86d/third_party/WebKit/LayoutTests/http/tests/locks/resources/sw-controlled-iframe.html
,
Jun 29 2018
,
Jun 29 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jsb...@chromium.org
, Jan 22 2018