New issue
Advanced search Search tips

Issue 804544 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 804546



Sign in to add a comment

Stop relying on blob UUIDs in CacheStorage code

Project Member Reported by mek@chromium.org, Jan 22 2018

Issue description

With blob mojofication completed CacheStorage code should now be able to deal with blobs without relying on their UUIDs, instead reading directly from the mojom::BlobPtr.
 

Comment 1 by mek@chromium.org, Jan 22 2018

Blocking: 804546
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff7914dc8b68f09484ab658a610b5adfbcbc1ac5

commit ff7914dc8b68f09484ab658a610b5adfbcbc1ac5
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jan 24 17:40:24 2018

Read blobs through their mojo interface in cache storage code.

Rather than relying on BlobProtocolHandler::CreateBlobRequest and the
URLRequest code path this just directly reads the blob.

Bug:  804544 

Change-Id: I9e181b9ec86f769060545e2f242f37474109e1b7
Reviewed-on: https://chromium-review.googlesource.com/879490
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531591}
[modify] https://crrev.com/ff7914dc8b68f09484ab658a610b5adfbcbc1ac5/content/browser/cache_storage/cache_storage_blob_to_disk_cache.cc
[modify] https://crrev.com/ff7914dc8b68f09484ab658a610b5adfbcbc1ac5/content/browser/cache_storage/cache_storage_blob_to_disk_cache.h
[modify] https://crrev.com/ff7914dc8b68f09484ab658a610b5adfbcbc1ac5/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc
[modify] https://crrev.com/ff7914dc8b68f09484ab658a610b5adfbcbc1ac5/content/browser/cache_storage/cache_storage_cache.cc

Comment 3 by mek@chromium.org, Apr 25 2018

Status: Fixed (was: Assigned)

Sign in to add a comment