New issue
Advanced search Search tips

Issue 804542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804533
issue 804587

Blocking:
issue 804585



Sign in to add a comment

Add EarlGrey integration tests for entering/exiting Tab Grid

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Add EarlGrey integration tests  for entering/exiting Tab Grid



 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-See-Open-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: medium

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804533

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: edchin@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Blockedon: 804587
Blocking: 804585
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe463c15b383607ffb7390e1efabb380a104a369

commit fe463c15b383607ffb7390e1efabb380a104a369
Author: edchin <edchin@chromium.org>
Date: Tue Mar 06 15:56:55 2018

[ios] Basic setup for tab grid egtests

This CL creates a single egtest for tab grid.

To achieve this:
- a new target was setup: ios_chrome_tab_grid_egtests.
- chrome_test_utils was updated to accommodate tab grid.
- creating a new tab and showing BVC was wired up.

Bug:  804542 ,  804585 ,  804587 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id7e359ef13d1d0b80d845b7787385123f4d42215
Reviewed-on: https://chromium-review.googlesource.com/949609
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541110}
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/app/tests_fake_hook.mm
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/app/tests_hook.h
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[add] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm
[add] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/tab_grid/tab_grid_egtests_hook.mm
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_eg_tests_hook.mm
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/test/app/chrome_test_util.mm
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/fe463c15b383607ffb7390e1efabb380a104a369/ios/chrome/test/earl_grey/eg_tests_hook.mm

NextAction: 2018-03-14
Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 7 2018

The NextAction date has arrived: 2018-03-14

Comment 15 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment