New issue
Advanced search Search tips

Issue 804540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804534



Sign in to add a comment

Build the animation for presenting from the grid when the active tab isn’t visible

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Build the animation for presenting from the grid when the active tab isn’t visible



Actual result:


 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-See-Open-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: medium

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804534

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Status: Assigned (was: Available)

Comment 7 by marq@chromium.org, Feb 28 2018

NextAction: 2018-03-14

Comment 8 by marq@chromium.org, Mar 9 2018

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6a1bec8aeafeba246857592d9743212d6164bc

commit cf6a1bec8aeafeba246857592d9743212d6164bc
Author: Mark Cogan <marq@google.com>
Date: Mon Mar 12 09:36:59 2018

[iOS] Animated transition from tab grid (selected tab not visible)

This is the animation when presenting a tab from the tab grid and the
current selected tab isn't visible (so the full grid zoom can't easily
be done). It would also be used when tapping 'done' while on the remote
tabs page.

This CL sets this to be the transition when presenting a tab in all
cases. A future CL will use the more detailed transition when it's
available.

The animation code is straightforward: set a zero alpha and scale
transform, then animate back to full alpha and the identity transform.

Bug:  804540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I58f6ac505352f39ffc9f92e2dc3b85898944a2df
Reviewed-on: https://chromium-review.googlesource.com/956147
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542447}
[modify] https://crrev.com/cf6a1bec8aeafeba246857592d9743212d6164bc/ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.mm
[modify] https://crrev.com/cf6a1bec8aeafeba246857592d9743212d6164bc/ios/chrome/browser/ui/tab_grid/transitions/grid_to_hidden_tab_animator.h
[modify] https://crrev.com/cf6a1bec8aeafeba246857592d9743212d6164bc/ios/chrome/browser/ui/tab_grid/transitions/grid_to_hidden_tab_animator.mm

Comment 10 by marq@chromium.org, Mar 12 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-14

Comment 12 by marq@chromium.org, Mar 15 2018

NextAction: ----

Sign in to add a comment