New issue
Advanced search Search tips

Issue 804537 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804534



Sign in to add a comment

Add a transition coordinators for presentation and dismissal of the tab grid.

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Add a transition coordinators for presentation and dismissal of the tab grid.

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-See-Open-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804534

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Status: Assigned (was: Available)

Comment 7 by marq@chromium.org, Feb 15 2018

NextAction: 2018-02-28

Comment 8 by marq@chromium.org, Feb 15 2018

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a

commit f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a
Author: Mark Cogan <marq@google.com>
Date: Sat Feb 17 06:20:39 2018

[iOS] Set up stub transition animators for Tab Grid.

This CL sets up stub implementations for the Tabb Grid transition
animators and helper objects/protocols.

Bug:  804537 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie030f3222a93774e9da6a90b02cd865350f2dd37
Reviewed-on: https://chromium-review.googlesource.com/924756
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537537}
[modify] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.h
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.mm
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/tab_grid_transition_state_provider.h
[modify] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h
[modify] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/transitions/BUILD.gn
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/transitions/grid_to_hidden_tab_animator.h
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/transitions/grid_to_hidden_tab_animator.mm
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/transitions/grid_to_visible_tab_animator.h
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/transitions/grid_to_visible_tab_animator.mm
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/transitions/tab_to_grid_animator.h
[add] https://crrev.com/f7e02c7a3f9e528c6277bc9042f2a1bccaafbc9a/ios/chrome/browser/ui/tab_grid/transitions/tab_to_grid_animator.mm

Comment 10 by marq@chromium.org, Feb 17 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-02-28

Comment 12 by cmasso@google.com, Feb 28 2018

NextAction: ----
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e9180fb33dd92f070ea54fe630084ea2e3001b4

commit 7e9180fb33dd92f070ea54fe630084ea2e3001b4
Author: edchin <edchin@chromium.org>
Date: Fri Mar 02 21:32:47 2018

[ios] TabGridAdaptor needs to implement setTransitionContext

This sets a stub implementation of setTransitionContext so that tab grid
can run on tablet. This implementation can eventually be removed when
the iPad-specific TabSwitcher is removed.

Bug:  804537 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3b5b8e7620d67c2d02a284b320df5ce003f78023
Reviewed-on: https://chromium-review.googlesource.com/946110
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540636}
[modify] https://crrev.com/7e9180fb33dd92f070ea54fe630084ea2e3001b4/ios/chrome/browser/ui/tab_grid/tab_grid_adaptor.mm

Sign in to add a comment