New issue
Advanced search Search tips

Issue 804536 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 804535



Sign in to add a comment

Update the active state if it changes, alongside the presentation animation

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Update the active state if it changes, alongside the presentation animation

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-See-Open-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804535

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Status: Assigned (was: Available)

Comment 7 by marq@chromium.org, Mar 15 2018

NextAction: 2018-03-28

Comment 8 by marq@chromium.org, Mar 19 2018

Status: Started (was: Assigned)

Comment 9 by cmasso@google.com, Mar 27 2018

Any update Mark?
The NextAction date has arrived: 2018-03-28

Comment 11 by cmasso@google.com, Apr 10 2018

Labels: -Q1 -Pri-2 Q2 Pri-0

Comment 12 by cmasso@google.com, Apr 11 2018

NextAction: ----

Comment 13 by marq@chromium.org, Apr 11 2018

NextAction: 2018-04-25
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/544572f1fe1fd1ff9338bc75db4210581d30e0e7

commit 544572f1fe1fd1ff9338bc75db4210581d30e0e7
Author: Mark Cogan <marq@google.com>
Date: Fri Apr 13 16:51:00 2018

[iOS] Tweak selection animation in tab grid transition

This CL fixes a bug where when zooming out from the tab grid, the
selection state change wasn't animated. It also makes the slection state
change animations longer.

Bug:  804536 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic3dba63a1c83bb967e66e110de299ce7cb898006
Reviewed-on: https://chromium-review.googlesource.com/1012073
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550650}
[modify] https://crrev.com/544572f1fe1fd1ff9338bc75db4210581d30e0e7/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm

Comment 15 by marq@chromium.org, Apr 13 2018

Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/544572f1fe1fd1ff9338bc75db4210581d30e0e7

commit 544572f1fe1fd1ff9338bc75db4210581d30e0e7
Author: Mark Cogan <marq@google.com>
Date: Fri Apr 13 16:51:00 2018

[iOS] Tweak selection animation in tab grid transition

This CL fixes a bug where when zooming out from the tab grid, the
selection state change wasn't animated. It also makes the slection state
change animations longer.

Bug:  804536 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic3dba63a1c83bb967e66e110de299ce7cb898006
Reviewed-on: https://chromium-review.googlesource.com/1012073
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550650}
[modify] https://crrev.com/544572f1fe1fd1ff9338bc75db4210581d30e0e7/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm

The NextAction date has arrived: 2018-04-25
NextAction: ----

Sign in to add a comment