Present from the tab grid when “done” is tapped. |
|||||||||
Issue descriptionPresent from the tab grid when “done” is tapped.
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Feb 28 2018
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/885d70868b4df78489e5b029ac6ddddd55882f26 commit 885d70868b4df78489e5b029ac6ddddd55882f26 Author: Mark Cogan <marq@google.com> Date: Thu Mar 01 21:17:02 2018 [iOS] Wire up "done" control in TabGrid toolbar. This CL adds a "tab presentation delegate" to the tab grid view controller, and has the coordinator implement that delegate protocol. For now, the path to actually trigger the presentation of the active tab goes through the tab switcher delegate (that is, MainController). Once there are fewer tab switchers to support, that can be cleaned up. Bug: 804534 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6d32e6c8145fe361ed4d6de51ced3d1178737a3d Reviewed-on: https://chromium-review.googlesource.com/942344 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540286} [modify] https://crrev.com/885d70868b4df78489e5b029ac6ddddd55882f26/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/885d70868b4df78489e5b029ac6ddddd55882f26/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h [modify] https://crrev.com/885d70868b4df78489e5b029ac6ddddd55882f26/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 1 2018
,
Mar 14 2018
The NextAction date has arrived: 2018-03-14
,
Mar 15 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)