Add cell subclass and flow layout subclass to the collection view
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f commit e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f Author: edchin <edchin@chromium.org> Date: Fri Feb 16 02:46:19 2018 [ios] First pass at GridCell This is a first pass at GridCell. Icon, title, close button, and the snapshot were added. Styling is already pretty close but will require more tweaking. A showcase entry displays various uses of this cell including different sizes and dark/light themes. This approach attempts to solve for dark variants without the need to subclass. Bug: 804526 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5bbeb5d8adb5ee93e6941d77bcac2b481569da74 Reviewed-on: https://chromium-review.googlesource.com/920627 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#537138} [modify] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/chrome/browser/ui/tab_grid/BUILD.gn [add] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/chrome/browser/ui/tab_grid/grid_cell.h [add] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/chrome/browser/ui/tab_grid/grid_cell.mm [add] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/chrome/browser/ui/tab_grid/grid_item.h [add] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/chrome/browser/ui/tab_grid/grid_item.mm [modify] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/showcase/core/showcase_model.mm [modify] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/showcase/tab_grid/BUILD.gn [add] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/showcase/tab_grid/sc_grid_cell_view_controller.h [add] https://crrev.com/e2ee6d3e38e4533ed3bac0659b2a3526d10c1b4f/ios/showcase/tab_grid/sc_grid_cell_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d0920af702072fba08a9dfe69375dcd79d4ee1f commit 6d0920af702072fba08a9dfe69375dcd79d4ee1f Author: edchin <edchin@chromium.org> Date: Thu Feb 22 03:21:42 2018 [ios] TopAlignedImageView This is a custom image view that aligns to the top of the image rather than to the center (as with a standard image view in aspect fill mode). This view is used in the TabGrid to show the more relevant part of the snapshot, which is the top-most portion. A showcase example is implemented in this CL, showing the difference between a standard ImageView and the new TopAlignedImageView. screenshot: https://drive.google.com/file/d/1ioylXSNAj54_RKa9joIPMYQMa2kErbm_ Bug: 804526 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I39d8d49e6d27b4a45ba1295df387b720a6deea10 Reviewed-on: https://chromium-review.googlesource.com/927828 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#538330} [modify] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/chrome/browser/ui/tab_grid/BUILD.gn [add] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/chrome/browser/ui/tab_grid/top_aligned_image_view.h [add] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/chrome/browser/ui/tab_grid/top_aligned_image_view.mm [modify] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/showcase/core/resources/BUILD.gn [add] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/showcase/core/resources/Sample-screenshot-portrait.png [modify] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/showcase/core/showcase_model.mm [modify] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/showcase/tab_grid/BUILD.gn [add] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/showcase/tab_grid/sc_image_view_controller.h [add] https://crrev.com/6d0920af702072fba08a9dfe69375dcd79d4ee1f/ios/showcase/tab_grid/sc_image_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/168431563679858b5133b02728d59c1164234ab5 commit 168431563679858b5133b02728d59c1164234ab5 Author: edchin <edchin@chromium.org> Date: Thu Feb 22 17:55:18 2018 [ios] Tab grid cell updates This CL updates the GridCell class with: - selection capability. - GridCellDelegate for informing the view controller that the close button was tapped. - properties for setting the icon and snapshot. - cleaner code. - updated showcase. Screenshot: https://drive.google.com/file/d/1ITqGgIaHPg07yZpdwIzxh9o-h8wTFcv6 Bug: 804526 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia87967a72974c93f4c4a02bcbcf8083ada19dada Reviewed-on: https://chromium-review.googlesource.com/928442 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#538478} [modify] https://crrev.com/168431563679858b5133b02728d59c1164234ab5/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/168431563679858b5133b02728d59c1164234ab5/ios/chrome/browser/ui/tab_grid/grid_cell.h [modify] https://crrev.com/168431563679858b5133b02728d59c1164234ab5/ios/chrome/browser/ui/tab_grid/grid_cell.mm [add] https://crrev.com/168431563679858b5133b02728d59c1164234ab5/ios/chrome/browser/ui/tab_grid/grid_theme.h [modify] https://crrev.com/168431563679858b5133b02728d59c1164234ab5/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm [modify] https://crrev.com/168431563679858b5133b02728d59c1164234ab5/ios/showcase/tab_grid/sc_grid_cell_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cad8668625f8c0bd3e4d10608b383e7741c0a88 commit 6cad8668625f8c0bd3e4d10608b383e7741c0a88 Author: edchin <edchin@chromium.org> Date: Fri Feb 23 22:35:27 2018 [ios] GridViewController improvements Improves GridViewController with: - uses GridLayout, a custom layout object. - implements GridConsumer. - calls GridCommands. - enables selection and closing items. - enables image retrieval. - light and dark themes. Bug: 804496 , 804526 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I41ef66f3d9efbe7d4f6a6bfe97db2123c0108880 Reviewed-on: https://chromium-review.googlesource.com/933582 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#538927} [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_cell.h [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_cell.mm [add] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_commands.h [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_consumer.h [add] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_image_data_source.h [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_item.h [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_item.mm [add] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_layout.h [add] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_layout.mm [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_view_controller.h [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm [modify] https://crrev.com/6cad8668625f8c0bd3e4d10608b383e7741c0a88/ios/showcase/tab_grid/sc_grid_coordinator.mm
The NextAction date has arrived: 2018-02-28
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)