New issue
Advanced search Search tips

Issue 804515 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Touchpad scroll continues after fingers have stopped

Project Member Reported by seobrien@chromium.org, Jan 22 2018

Issue description

Chrome Version: 65.0.3325.0
Chrome OS Version: 10323.0.0
Chrome OS Platform: 10323.0.0 (Official Build) dev-channel eve test

Steps To Reproduce:
(1) Build with "Max Stationary Move Speed" option for gesture library set to 35.
(2) Scroll with two fingers.
(3) Stop scrolling but don't lift fingers.

Expected Result:
Page should scroll and then stop with fingers

Actual Result:
Page continues scrolling indefinitely after fingers stop.

How frequently does this problem reproduce? sometimes

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/gestures/+/9956ad407739299ace45863589296d49f416a4d6

commit 9956ad407739299ace45863589296d49f416a4d6
Author: Sean O'Brien <seobrien@google.com>
Date: Wed Feb 14 05:15:26 2018

Separate logic for finger suppression reasons

Currently, we can suppress fingers when they are either stationary or
when pressure is changing significantly.  In either case, we may
continue to send scrolls using dead reckoning from previous scrolls.
When stationary finger suppression is enabled, stationary fingers may
continue to generate scroll gestures indefinitely.

This CL makes it so stationary fingers will only send zero-length
scrolls, instead of scrolls using dead reckoning.  Fingers with
significant pressure change will still send dead reckoning scrolls.

This CL also changes the criteria for stationary finger suppression.
Before a finger was considered not stationary if the sum finger movement
from frame to frame exceeded the threshold.  This meant that a finger
which appears stationary would accrue enough small movement to pass this
threshold.

Now the difference in finger position from the first stationary moment
to now must exceed the threshold, so minor movements which cancel out
won't add up.

BUG= chromium:804515 
TEST=Test on eve, samus, and swanky. Check for regressions on touchtests suite.
CQ-DEPEND=CL:881645

Change-Id: I5195a1f0e9cbd405babbfd390a912ffa62ae2349
Reviewed-on: https://chromium-review.googlesource.com/879743
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/9956ad407739299ace45863589296d49f416a4d6/include/immediate_interpreter.h
[modify] https://crrev.com/9956ad407739299ace45863589296d49f416a4d6/src/immediate_interpreter.cc
[modify] https://crrev.com/9956ad407739299ace45863589296d49f416a4d6/src/immediate_interpreter_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment