eve-paladin failed to rebuild previously removed factory-board ebuild |
||||||||
Issue descriptionhttp://crrev.com/i/551123 removed the factory-board ebuild. Today, http://crrev.com/c/770257 introduced an unrelated change to vboot_reference. factory-board depends on vboot_reference, so eve-paladin decided to rebuild it. Since it was no longer there, the build failed with error "chromeos-base/factory-board-1.0.0-r9::eve-private (masked by: need to rebuild from source)". This looks like another instance of https://crbug.com/804406, where stale stuff is left over in the chroot. https://luci-milo.appspot.com/buildbot/chromeos/eve-paladin/2183
,
Jan 22 2018
The next run created a new chroot and failed with the same error. Checking to see why a fresh chroot still contains the removed package.
,
Jan 22 2018
,
Jan 23 2018
Bumping priority, since this is apparently blocking commits to vboot_reference. Can we just revert http://crrev.com/i/551123 while we solve the underlying problem?
,
Jan 23 2018
this is WAI from the packaging side, more or less. if you want to purge the package, you can add a chroot hook script to remove it everywhere. look at src/scripts/chroot_version_hooks.d/135_clean_linux-3.4 as an example.
,
Jan 23 2018
Re #5: Shouldn't a fresh chroot not contain the removed package, though? I just created a new chroot on my workstation and factory-board wasn't there.
,
Jan 23 2018
yes, a new chroot (or really blowing /build/$BOARD away) would not re-install the package. but most paladins (by design) don't do either of those things.
,
Jan 23 2018
,
Jan 23 2018
This build seems to have started from a fresh chroot, but then it failed with the factory-board references: https://luci-milo.appspot.com/buildbot/chromeos/eve-paladin/2184 . Am I missing something there?
,
Jan 23 2018
hungte@, could you take a look and see if you missed a step when removing factory-board?
,
Jan 23 2018
Re#5 We may need to do this often and I'm not sure if that will mess up chroot version....? I'm planning to add a dummy ebuild to help existing chroot devices to empty the dependency between factory-board and vboot_reference. Then in the future after most paladins have been updated, we can remove the dummy one.
,
Jan 23 2018
,
Jan 23 2018
1) I see the same issue with the local build. Note that I have vboot_reference along with a few other packages in my cros_workon list. Going through repo sync, deleting /build/eve, recreating chroot didn't help. 2) The workaround from #12 works (still building, but got past that point, so no surprises).
,
Jan 23 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/b983052e9a2cdbb62dd4fca0655aec6614d05c71 commit b983052e9a2cdbb62dd4fca0655aec6614d05c71 Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Jan 23 09:48:52 2018
,
Jan 23 2018
CL merged. Let me know if you see more problems.
,
Jan 23 2018
Thanks for the quick fix!
,
Jan 23 2018
The next eve-paladin run passed BuildPackages with the original vboot change: https://luci-milo.appspot.com/buildbot/chromeos/eve-paladin/2190 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bmgordon@chromium.org
, Jan 22 2018