New issue
Advanced search Search tips

Issue 804506 link

Starred by 1 user
Status: Verified
Owner:
katie@chromium.org
Closed: Feb 2018
Cc:
lpalmaro@chromium.org
katie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
STS
Team-Accessibility



Sign in to add a comment

CrOS A11y: Select To Speak should be listed in the status bar > Accessibility menu

Project Member Reported by leberly@chromium.org, Jan 22 2018 
Google Chrome	65.0.3322.0 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

In the Status Bar > Accessibility menu, many options are listed but Select To Speak is absent. Users should be able to see it listed here and have the ability to check/uncheck right from the status bar like the other features. 

This is a feature request from me, a STS user, and also from an end user in the axs-chrome-discuss mailing list.

Comment 1 by katie@chromium.org, Jan 22 2018

Cc: lpalmaro@chromium.org
Labels: STS
+Laura A, do we need a launch request for this? Maybe an icon?

Comment 2 by lpalmaro@google.com, Jan 26 2018

Labels: M-66

Comment 3 by katie@chromium.org, Jan 26 2018

Owner: katie@chromium.org
Status: Assigned (was: Available)

Comment 4 by katie@chromium.org, Feb 7 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8965b37fb03e4e90739096bf4ce1defbfb594fb6

commit 8965b37fb03e4e90739096bf4ce1defbfb594fb6
Author: Katie D <katie@chromium.org>
Date: Fri Feb 09 20:39:59 2018

Add Select-to-Speak to accessibility menu in status tray.

Includes new icon for Select-to-Speak.
Having STS in the status tray was approved by UX over email, so this is
not behind any flags.

Bug:  804506 
Change-Id: Icdeda04e2c10db7ba891cfed585db0027dcb97b5
Reviewed-on: https://chromium-review.googlesource.com/904968
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535813}
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/ash_strings.grd
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.1x.icon
[add] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.icon
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/system/tray_accessibility.cc
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/ash/system/tray_accessibility.h
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/8965b37fb03e4e90739096bf4ce1defbfb594fb6/tools/metrics/actions/actions.xml

Comment 6 by katie@chromium.org, Feb 9 2018

Labels: a11y-testers
Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f251a33e51ab0c4b757c6f1bfafb67db628854ef

commit f251a33e51ab0c4b757c6f1bfafb67db628854ef
Author: Megan Jablonski <megjablon@chromium.org>
Date: Sat Feb 10 00:45:31 2018

Revert "Add Select-to-Speak to accessibility menu in status tray."

This reverts commit 8965b37fb03e4e90739096bf4ce1defbfb594fb6.

Reason for revert: TrayAccessibilityTestInstance tests failing on bots

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-dbg

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-dbg/builds/4171

Original change's description:
> Add Select-to-Speak to accessibility menu in status tray.
> 
> Includes new icon for Select-to-Speak.
> Having STS in the status tray was approved by UX over email, so this is
> not behind any flags.
> 
> Bug:  804506 
> Change-Id: Icdeda04e2c10db7ba891cfed585db0027dcb97b5
> Reviewed-on: https://chromium-review.googlesource.com/904968
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#535813}

TBR=jamescook@chromium.org,tbarzic@chromium.org,dmazzoni@chromium.org,isherman@chromium.org,katie@chromium.org

Change-Id: Iba6c1fb5b36483bfd75adcde1e67e8036ad0d5a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  804506 
Reviewed-on: https://chromium-review.googlesource.com/911884
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535904}
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/ash_strings.grd
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/b62c1a3ce3eb018c3c3c2078565188ce64cc96c6/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.1x.icon
[delete] https://crrev.com/b62c1a3ce3eb018c3c3c2078565188ce64cc96c6/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.icon
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/system/tray_accessibility.cc
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/ash/system/tray_accessibility.h
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/f251a33e51ab0c4b757c6f1bfafb67db628854ef/tools/metrics/actions/actions.xml

Comment 8 by katie@chromium.org, Feb 12 2018

Status: Started (was: Fixed)
Test fix & revert is in progress...
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1e4da67bd310563da252e6db49792c05baf1ae

commit 6c1e4da67bd310563da252e6db49792c05baf1ae
Author: Katie D <katie@chromium.org>
Date: Mon Feb 12 20:45:42 2018

Revert "Revert "Add Select-to-Speak to accessibility menu in status tray.""

This reverts commit f251a33e51ab0c4b757c6f1bfafb67db628854ef.

The failing tests in linux-chromeos-dbg have been fixed, re-submitting
the original change with that fix.

The fix is to clamp the opacity in AccessibilityLayer::SetOpacity to 0
if it is below 0. The bug seemed to have been floating point math error.

TBR=dmazzoni@chromium.org,tbarzic@chromium.org,jamescook@chromium.org,isherman@chromium.org,megjablon@chromium.org

Bug:  804506 
Change-Id: I51a6e56a1814b054722f35672fe5309fe3609de6
Reviewed-on: https://chromium-review.googlesource.com/914088
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536178}
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/accessibility/accessibility_layer.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/ash_strings.grd
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.1x.icon
[add] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.icon
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/system/tray_accessibility.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/ash/system/tray_accessibility.h
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/6c1e4da67bd310563da252e6db49792c05baf1ae/tools/metrics/actions/actions.xml
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6f8447711fcc2d4a722adab83e823c0a382a0a

commit 5b6f8447711fcc2d4a722adab83e823c0a382a0a
Author: Katie Dektar <katie@chromium.org>
Date: Tue Feb 13 04:08:15 2018

Revert "Revert "Revert "Add Select-to-Speak to accessibility menu in status tray."""

This reverts commit 6c1e4da67bd310563da252e6db49792c05baf1ae.

Reason for revert: Causes a failure in Linux ChromiumOS MSan Tests
See: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZjMWU0ZGE2N2JkMzEwNTYzZGEyNTJlNmRiNDk3OTJjMDViYWYxYWUM

This change has caused several failures because it loads Select-to-Speak
in tests where it was never loaded before. I'll take a look at these
memory failures and try to get a fix out tomorrow to re-land this again.

Original change's description:
> Revert "Revert "Add Select-to-Speak to accessibility menu in status tray.""
> 
> This reverts commit f251a33e51ab0c4b757c6f1bfafb67db628854ef.
> 
> The failing tests in linux-chromeos-dbg have been fixed, re-submitting
> the original change with that fix.
> 
> The fix is to clamp the opacity in AccessibilityLayer::SetOpacity to 0
> if it is below 0. The bug seemed to have been floating point math error.
> 
> TBR=dmazzoni@chromium.org,tbarzic@chromium.org,jamescook@chromium.org,isherman@chromium.org,megjablon@chromium.org
> 
> Bug:  804506 
> Change-Id: I51a6e56a1814b054722f35672fe5309fe3609de6
> Reviewed-on: https://chromium-review.googlesource.com/914088
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536178}

TBR=jamescook@chromium.org,tbarzic@chromium.org,dmazzoni@chromium.org,isherman@chromium.org,katie@chromium.org

Change-Id: I07b0edb19e504fac5853f276717650666baf0aa8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  804506 
Reviewed-on: https://chromium-review.googlesource.com/915562
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536255}
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/accessibility/accessibility_layer.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/ash_strings.grd
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/bf820f4d038ccfa656ea155fdbeece61949f4351/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.1x.icon
[delete] https://crrev.com/bf820f4d038ccfa656ea155fdbeece61949f4351/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.icon
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/system/tray_accessibility.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/ash/system/tray_accessibility.h
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/5b6f8447711fcc2d4a722adab83e823c0a382a0a/tools/metrics/actions/actions.xml

Comment 12 by katie@chromium.org, Feb 13 2018

Status: Started (was: Fixed)
It broke another bot after submit. Looking again...
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6af68c5e462a8a535d82f6634cea71cb9581427a

commit 6af68c5e462a8a535d82f6634cea71cb9581427a
Author: Katie D <katie@chromium.org>
Date: Wed Feb 14 23:21:16 2018

Reland "Add Select-to-Speak to accessibility menu in status tray."

This reverts commit 5b6f8447711fcc2d4a722adab83e823c0a382a0a.

I've tried to fix the memory errors found after commit last time.
Hopefully this will pass all bots.

Original change's description:
> Revert "Revert "Revert "Add Select-to-Speak to accessibility menu in status tray."""
>
> This reverts commit 6c1e4da67bd310563da252e6db49792c05baf1ae.
>
> Reason for revert: Causes a failure in Linux ChromiumOS MSan Tests
> See: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZjMWU0ZGE2N2JkMzEwNTYzZGEyNTJlNmRiNDk3OTJjMDViYWYxYWUM
>
> This change has caused several failures because it loads Select-to-Speak
> in tests where it was never loaded before. I'll take a look at these
> memory failures and try to get a fix out tomorrow to re-land this again.

TBR=jamescook@chromium.org,tbarzic@chromium.org,dmazzoni@chromium.org,isherman@chromium.org

Bug:  804506 
Change-Id: I00b4e2920b20f0064d075b911d22a1ec64407e3f
Reviewed-on: https://chromium-review.googlesource.com/916709
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536874}
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/accessibility/accessibility_focus_ring_controller.h
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/accessibility/accessibility_layer.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/ash_strings.grd
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.1x.icon
[add] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.icon
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/system/tray_accessibility.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/ash/system/tray_accessibility.h
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/6af68c5e462a8a535d82f6634cea71cb9581427a/tools/metrics/actions/actions.xml

Comment 14 by katie@chromium.org, Feb 14 2018

Status: Fixed (was: Started)

Comment 15 by leberly@chromium.org, Mar 16 2018

Labels: -a11y-testers
Status: Verified (was: Fixed)
Google Chrome 67.0.3369.0 (Official Build) canary (64-bit)
Firmware Version Google_Samus.6300.276.0
Flag enabled: #enable-experimental-accessibility-features

STS is available in the Accessibility settings in the status bar. It is able to be toggled on and off using the mouse and the feature properly toggles on and off to match the UI. STS reads the text in this menu.

Comment 16 by leberly@chromium.org, Apr 10 2018

Components: UI>Accessibility>SelectToSpeak
Moving from just having STS label to also having the UI>Accessibility>SelectToSpeak component to make searching easier in the future.
►

Sign in to add a comment