New issue
Advanced search Search tips

Issue 804501 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804500



Sign in to add a comment

Show correct tab counts in the segmented view

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Show correct tab counts in the segmented view

 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-See-Open-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804500

Comment 5 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 6 by marq@chromium.org, Jan 25 2018

Status: Assigned (was: Available)

Comment 7 by marq@chromium.org, Feb 28 2018

NextAction: 2018-03-14

Comment 8 by marq@chromium.org, Mar 13 2018

Status: Started (was: Assigned)
The NextAction date has arrived: 2018-03-14

Comment 10 by marq@chromium.org, Mar 15 2018

NextAction: 2018-03-28
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50905e908c1d8b750e730861696d59872d4c99eb

commit 50905e908c1d8b750e730861696d59872d4c99eb
Author: Mark Cogan <marq@google.com>
Date: Fri Mar 16 16:02:56 2018

[iOS] Update tab counts in tab grid page control.

This CL wires the tab grid page controls tab counts into the grid
view controllers. To do this, a public |itemCount| property is added to
the GridViewControllers, and the TabGridViewController updates the
counts in the page control whenever an event occurs that would change
the count (opening or closing a tab), and when the VC is initially set
up.

Bug:  804501 ,  804552 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9162b45e04b102ce4c1b885356ebf3bf0873396b
Reviewed-on: https://chromium-review.googlesource.com/964143
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543716}
[modify] https://crrev.com/50905e908c1d8b750e730861696d59872d4c99eb/ios/chrome/browser/ui/tab_grid/grid_view_controller.h
[modify] https://crrev.com/50905e908c1d8b750e730861696d59872d4c99eb/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm
[modify] https://crrev.com/50905e908c1d8b750e730861696d59872d4c99eb/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.h
[modify] https://crrev.com/50905e908c1d8b750e730861696d59872d4c99eb/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm
[modify] https://crrev.com/50905e908c1d8b750e730861696d59872d4c99eb/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Comment 12 by marq@chromium.org, Mar 16 2018

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Issue verified 
Version: Chrome Canary 67.0.3376.0
Device: iPhone 6 Plus
iOS: 11.2.6

Tab grid count correctly updated,. Numbers greater than 99 are displayed as ':-)'
https://drive.google.com/open?id=1eoQHORMWD7a89Exw4oE-TLH69PGXCHEM
The NextAction date has arrived: 2018-03-28

Sign in to add a comment