Create the custom segmented view
The NextAction date has arrived: 2018-03-14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f53bc613f93665b1c68d98cfd5f1a201dc5d7893 commit f53bc613f93665b1c68d98cfd5f1a201dc5d7893 Author: Mark Cogan <marq@google.com> Date: Thu Mar 15 16:13:41 2018 [iOS] Page selection control for the tab grid. This CL creates the custom selection control for the tab grid and wires it into the TabGridViewController. There are extensive comments in the TabGridPageSelector class. Some things to note: * Labels are used in place of assets for now. * Dragging the slider in the control isn't possible yet. * The view controller doesn't yet update the tab counts in the control. Bug: 804500 , 804581 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If561619091271b7086989f68bb76edb5bd64c16b Reviewed-on: https://chromium-review.googlesource.com/962791 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543388} [modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/BUILD.gn [add] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.h [add] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm [modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.h [modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm [modify] https://crrev.com/f53bc613f93665b1c68d98cfd5f1a201dc5d7893/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/041ef26410ec7b2840c98970ea16b4c3c0f2b412 commit 041ef26410ec7b2840c98970ea16b4c3c0f2b412 Author: Mark Cogan <marq@google.com> Date: Tue Mar 20 16:17:54 2018 [iOS] Have tab grid page control slider move on scroll deceleration. This CL has the slider on the tab grid page control move as the tab grid scroll view decelerates after a drag, as well as while dragging. Bug: 804500 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic3d35b1abd4e588f212b59ebf72027fe4ce040ff Reviewed-on: https://chromium-review.googlesource.com/970480 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544392} [modify] https://crrev.com/041ef26410ec7b2840c98970ea16b4c3c0f2b412/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
Issue 823821 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0629986be90ad055c2ac8fbfa46fed2280bcd953 commit 0629986be90ad055c2ac8fbfa46fed2280bcd953 Author: Mark Cogan <marq@google.com> Date: Tue Mar 20 22:08:11 2018 [iOS] Add tab grid page control assets. This CL adds assets to the tab grid page control. The selected-state assets provided are the same size as the non-selected assets. Since the UX shows a slightly enlarged icon in the selected state, this CL adds a scaling transform to the selected images. This will be removed when the correctly sized assets are available. Faux asset views are removed. This CL also removes the incognito tab count label on the page control. It may be added later pending UX discussions. Bug: 804500 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e1ed6931dd71c0a2b4a0a7f7d5a2f1a1f194b1e Reviewed-on: https://chromium-review.googlesource.com/970655 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544551} [modify] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/BUILD.gn [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs.imageset/Contents.json [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs.imageset/page_control_incognito_tabs.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs.imageset/page_control_incognito_tabs@2x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs.imageset/page_control_incognito_tabs@3x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs_selected.imageset/Contents.json [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs_selected.imageset/page_control_incognito_tabs_selected.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs_selected.imageset/page_control_incognito_tabs_selected@2x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_incognito_tabs_selected.imageset/page_control_incognito_tabs_selected@3x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs.imageset/Contents.json [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs.imageset/page_control_regular_tabs.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs.imageset/page_control_regular_tabs@2x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs.imageset/page_control_regular_tabs@3x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs_selected.imageset/Contents.json [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs_selected.imageset/page_control_regular_tabs_selected.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs_selected.imageset/page_control_regular_tabs_selected@2x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_regular_tabs_selected.imageset/page_control_regular_tabs_selected@3x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs.imageset/Contents.json [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs.imageset/page_control_remote_tabs.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs.imageset/page_control_remote_tabs@2x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs.imageset/page_control_remote_tabs@3x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs_selected.imageset/Contents.json [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs_selected.imageset/page_control_remote_tabs_selected.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs_selected.imageset/page_control_remote_tabs_selected@2x.png [add] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/resources/page_control_remote_tabs_selected.imageset/page_control_remote_tabs_selected@3x.png [modify] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.h [modify] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm [modify] https://crrev.com/0629986be90ad055c2ac8fbfa46fed2280bcd953/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
Marking done now that assets are added.
Verified in 67.0.3380.0 Canary, iPhone X iOS 11.2, Tab grid UI looks good. https://drive.google.com/file/d/1l3VU13L6WoZMS7w2bgWjGpzxCdPeZvcG/view
The NextAction date has arrived: 2018-03-28
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)