Add toolbar views to the view controller |
|||||||||||||||||||
Issue descriptionAdd toolbar views to the view controller
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
,
Jan 25 2018
,
Feb 15 2018
,
Feb 16 2018
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7138892f3594182055e60b713494123f75f49b25 commit 7138892f3594182055e60b713494123f75f49b25 Author: edchin <edchin@chromium.org> Date: Fri Feb 16 23:08:21 2018 [ios] Tab grid toolbars initial implementations Bug: 804499 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I066fc6b53f8f2775f559f8dd75ab63d629b74e9d Reviewed-on: https://chromium-review.googlesource.com/924381 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#537447} [modify] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/chrome/browser/ui/tab_grid/BUILD.gn [add] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.h [add] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm [add] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.h [add] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm [modify] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/showcase/core/showcase_model.mm [modify] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/showcase/tab_grid/BUILD.gn [add] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/showcase/tab_grid/sc_tab_grid_coordinator.h [add] https://crrev.com/7138892f3594182055e60b713494123f75f49b25/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f50f93d24ad8f9e2413f851f28d05c1762c73e0 commit 1f50f93d24ad8f9e2413f851f28d05c1762c73e0 Author: edchin <edchin@chromium.org> Date: Thu Feb 22 04:04:47 2018 [ios] Add showcase for tab grid toolbars Snapshot: https://drive.google.com/file/d/1njQHtrmrMj6qDI6s4r7-0e2pzP3zb4QG Bug: 804499 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I21147d3460424f8124b96a3292ed604cbebf1407 Reviewed-on: https://chromium-review.googlesource.com/927941 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#538343} [modify] https://crrev.com/1f50f93d24ad8f9e2413f851f28d05c1762c73e0/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.h [modify] https://crrev.com/1f50f93d24ad8f9e2413f851f28d05c1762c73e0/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm [modify] https://crrev.com/1f50f93d24ad8f9e2413f851f28d05c1762c73e0/ios/showcase/core/showcase_model.mm [modify] https://crrev.com/1f50f93d24ad8f9e2413f851f28d05c1762c73e0/ios/showcase/tab_grid/BUILD.gn [add] https://crrev.com/1f50f93d24ad8f9e2413f851f28d05c1762c73e0/ios/showcase/tab_grid/sc_toolbars_view_controller.h [add] https://crrev.com/1f50f93d24ad8f9e2413f851f28d05c1762c73e0/ios/showcase/tab_grid/sc_toolbars_view_controller.mm
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29 commit 6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29 Author: edchin <edchin@chromium.org> Date: Wed Feb 28 01:13:53 2018 [ios] TabGridViewController improvements This CL refines the TabGridViewController to include the scroll view, incognito tabs, regular tabs, placeholder for remote tabs, top toolbar, bottom toolbar, the floating action button. Protocols are used to expose delegates, image data sources, and consumers to the outside world. Bug: 804496 , 804499 , 804497 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3bc3e6b391f50a183b6b4e8103a32dbc0ee34ec1 Reviewed-on: https://chromium-review.googlesource.com/936041 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539610} [modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/grid_layout.mm [modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h [modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm
,
Feb 28 2018
The NextAction date has arrived: 2018-02-28
,
Feb 28 2018
,
Mar 2 2018
The toolbars are roughly done (minus the segmented control). The remaining polish work can only be done after UX delivers a spec. I consolidated all spec-driven work to another task that is blocked on UX. See this task: https://bugs.chromium.org/p/chromium/issues/detail?id=818198
,
Mar 13 2018
Realized that this should have included setting the right toolbars for the current size class. This CL is in-flight and bumps this task to medium.
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21a15b2820ae0fe8cb98ea1f33fb0a3054830145 commit 21a15b2820ae0fe8cb98ea1f33fb0a3054830145 Author: edchin <edchin@chromium.org> Date: Tue Mar 13 16:17:45 2018 [ios] Setup tab grid toolbars for current size class This CL configures the tab grid toolbars for the current size class. For example, a portrait phone will have a bottom toolbar whereas an iPad will have a FAB. This CL configures based on size classes, not device idioms. Bug: 804499 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I56cb26e43f92ee6152bd5b1e1d747bafbc052880 Reviewed-on: https://chromium-review.googlesource.com/959921 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542820} [modify] https://crrev.com/21a15b2820ae0fe8cb98ea1f33fb0a3054830145/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 13 2018
,
Mar 14 2018
The NextAction date has arrived: 2018-03-14
,
Mar 14 2018
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by marq@chromium.org
, Jan 23 2018Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)