New issue
Advanced search Search tips

Issue 804497 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 804496

Blocking:
issue 804498



Sign in to add a comment

Add the view controller to Showcase

Project Member Reported by marq@chromium.org, Jan 22 2018

Issue description

Add the view controller to Showcase




 

Comment 1 by marq@chromium.org, Jan 23 2018

Components: UI>Browser
Labels: MS-Tab-Grid Pri-2
Owner: marq@chromium.org
Status: Available (was: Unconfirmed)

Comment 2 by marq@chromium.org, Jan 23 2018

Labels: S-See-Open-Tabs

Comment 3 by marq@chromium.org, Jan 23 2018

Labels: small

Comment 4 by marq@chromium.org, Jan 23 2018

Blockedon: 804496

Comment 5 by marq@chromium.org, Jan 23 2018

Blocking: 804498

Comment 6 by marq@chromium.org, Jan 23 2018

Labels: Q1

Comment 7 by marq@chromium.org, Jan 25 2018

Cc: marq@chromium.org
Owner: edchin@chromium.org
Status: Assigned (was: Available)

Comment 8 by edchin@chromium.org, Feb 14 2018

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4244ba15340f927a04fc6e35c851997653fed0

commit 7c4244ba15340f927a04fc6e35c851997653fed0
Author: edchin <edchin@chromium.org>
Date: Wed Feb 14 21:04:04 2018

[ios showcase] Add tab grid to showcase

This CL simply adds the tab_grid_view_controller to showcase.

Bug:  804497 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic8eb2ebd793f4dfec7f17d237818f7991ed70c91
Reviewed-on: https://chromium-review.googlesource.com/919071
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536815}
[modify] https://crrev.com/7c4244ba15340f927a04fc6e35c851997653fed0/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/7c4244ba15340f927a04fc6e35c851997653fed0/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/7c4244ba15340f927a04fc6e35c851997653fed0/ios/showcase/BUILD.gn
[modify] https://crrev.com/7c4244ba15340f927a04fc6e35c851997653fed0/ios/showcase/core/showcase_model.mm
[add] https://crrev.com/7c4244ba15340f927a04fc6e35c851997653fed0/ios/showcase/tab_grid/BUILD.gn
[add] https://crrev.com/7c4244ba15340f927a04fc6e35c851997653fed0/ios/showcase/tab_grid/sc_tab_grid_coordinator.h
[add] https://crrev.com/7c4244ba15340f927a04fc6e35c851997653fed0/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm

NextAction: 2018-02-28
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29

commit 6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29
Author: edchin <edchin@chromium.org>
Date: Wed Feb 28 01:13:53 2018

[ios] TabGridViewController improvements

This CL refines the TabGridViewController to include the scroll view,
incognito tabs, regular tabs, placeholder for remote tabs, top toolbar,
bottom toolbar, the floating action button. Protocols are used to
expose delegates, image data sources, and consumers to the outside
world.

Bug:  804496 ,  804499 ,  804497 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3bc3e6b391f50a183b6b4e8103a32dbc0ee34ec1
Reviewed-on: https://chromium-review.googlesource.com/936041
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539610}
[modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/grid_layout.mm
[modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h
[modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/6f60fb4fa01f7df5713ad4d0bbdd77801a3d3c29/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm

The NextAction date has arrived: 2018-02-28

Comment 14 by cmasso@google.com, Feb 28 2018

NextAction: 2018-03-14
Status: Fixed (was: Started)
The NextAction date has arrived: 2018-03-14

Comment 17 by marq@chromium.org, Mar 15 2018

NextAction: ----

Sign in to add a comment