New issue
Advanced search Search tips

Issue 804478 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

GPU Discardable memory should unbind client-side bindings on unlock

Project Member Reported by ericrk@chromium.org, Jan 22 2018

Issue description

Currently, when a GPU discardable entry is unlocked, it clears any texture bindings on the GPU service side. These are also tracked on the client side. We should clear those too.

See client side code here:
https://cs.chromium.org/chromium/src/gpu/command_buffer/client/gles2_implementation.cc?rcl=faa2517606be8ddd20b15449b0644699728f8a66&l=4668
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9cc5226db4f425c2dca8b0948d3ac36a99888b6

commit e9cc5226db4f425c2dca8b0948d3ac36a99888b6
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Jan 24 17:54:32 2018

Unbind discardable textures on client side on unlock

Currently, when a GPU discardable entry is unlocked, it clears any
texture bindings on the GPU service side. These are also tracked on the
client side. With this change, we clear client side bindings as well.

R=piman

Bug:  804478 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I73d2cefb72fcc4e6a4302b83de55ff850038c0ca
Reviewed-on: https://chromium-review.googlesource.com/879545
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531599}
[modify] https://crrev.com/e9cc5226db4f425c2dca8b0948d3ac36a99888b6/gpu/command_buffer/client/client_discardable_texture_manager.cc
[modify] https://crrev.com/e9cc5226db4f425c2dca8b0948d3ac36a99888b6/gpu/command_buffer/client/client_discardable_texture_manager.h
[modify] https://crrev.com/e9cc5226db4f425c2dca8b0948d3ac36a99888b6/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/e9cc5226db4f425c2dca8b0948d3ac36a99888b6/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/e9cc5226db4f425c2dca8b0948d3ac36a99888b6/gpu/command_buffer/client/gles2_implementation_unittest.cc

Comment 2 by ericrk@chromium.org, Jan 24 2018

Status: Fixed (was: Started)

Sign in to add a comment