New issue
Advanced search Search tips

Issue 804472 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Jan 2018
Cc:
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

In update_client, emit different events in the noupdate and update error cases.

Project Member Reported by sorin@chromium.org, Jan 22 2018 
The current subject-observer implementation in the update_client emits the event UpdateClient::Observer::Events::COMPONENT_NOT_UPDATED when a component was not updated for any reason. 

For some clients it matters if the COMPONENT_NOT_UPDATED occured when there was no update for the component vs. there was an update but an error occurred while handling it.

This change separates the two reasons COMPONENT_NOT_UPDATED could be emitted and it introduces a distinct COMPONENT_UPDATE_ERROR.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbb10e171054a20ade042fa738eea27b1b28b9ef

commit cbb10e171054a20ade042fa738eea27b1b28b9ef
Author: Sorin Jianu <sorin@chromium.org>
Date: Tue Jan 23 18:01:44 2018

In update_client, emit different events in the noupdate and update error cases.

Bug:  804472 
Change-Id: I0425bcea8cd82386dbcd0fe63fa696e60a468af2
Reviewed-on: https://chromium-review.googlesource.com/879165
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531276}
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/chrome/app/generated_resources.grd
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/components/update_client/component.cc
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/components/update_client/update_client.h
[modify] https://crrev.com/cbb10e171054a20ade042fa738eea27b1b28b9ef/components/update_client/update_client_unittest.cc

Comment 2 by sorin@chromium.org, Jan 24 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment