Issue metadata
Sign in to add a comment
|
Cursor regression in multi-display ARC |
||||||||||||||||||||
Issue descriptionWhen an ARC window is dragged to a display with a different density, the cursor scale on that display is incorrect until the window is dropped.
,
Jan 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/314513713e5fe647c2bfa8935550c94b7cc21391 commit 314513713e5fe647c2bfa8935550c94b7cc21391 Author: Mitsuru Oshima <oshima@chromium.org> Date: Sun Jan 28 02:25:08 2018 Update cursor when it moves to different display. Old remote shell drag used to capture the surface during drag because motion events have to be sent to android. And cursor update logic was depending on this behavior. This is no longer true in chrome driven drag&resize and the capture is now on the remote shell's widget (same as xdg). This CL makes the update logic independent of focus surface, and updates the cursor if the cursor created by this when moves to different display. BUG= 804471 TEST=manual Change-Id: I8dc7a6fdc6f87c7b3872e54d7a61f43e2904b263 Reviewed-on: https://chromium-review.googlesource.com/882191 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532264} [modify] https://crrev.com/314513713e5fe647c2bfa8935550c94b7cc21391/components/exo/pointer.cc [modify] https://crrev.com/314513713e5fe647c2bfa8935550c94b7cc21391/components/exo/wm_helper.cc [modify] https://crrev.com/314513713e5fe647c2bfa8935550c94b7cc21391/components/exo/wm_helper.h
,
Jan 28 2018
,
Jan 29 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ad57407657a2c94f7b013ec0d2b5eb5fb46fb68 commit 9ad57407657a2c94f7b013ec0d2b5eb5fb46fb68 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Jan 31 01:19:23 2018 Do not lock the cursor when dragging a client controlled window Do not lock the cursor when dragging a window whose state is controlled by a client, which may set its own cursor during drag. Better fix is to add custom cursor API that supports density change. We'll address it as a part of cursor improvement work. (b/80666810, crbug.com/721601) BUG= 804471 TEST=manual Change-Id: I4ddb5a96d820cca1fa08528adf8e311c5a0960e7 Reviewed-on: https://chromium-review.googlesource.com/881526 Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531391}(cherry picked from commit 3806eaaeb33fa8c9a9f091c31cb3579fb5b499ee) Reviewed-on: https://chromium-review.googlesource.com/894288 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#189} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/9ad57407657a2c94f7b013ec0d2b5eb5fb46fb68/ash/wm/workspace/workspace_window_resizer.cc
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe85dae543740ea119d1115e2f2814977f535152 commit fe85dae543740ea119d1115e2f2814977f535152 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Jan 31 01:22:46 2018 Update cursor when it moves to different display. Old remote shell drag used to capture the surface during drag because motion events have to be sent to android. And cursor update logic was depending on this behavior. This is no longer true in chrome driven drag&resize and the capture is now on the remote shell's widget (same as xdg). This CL makes the update logic independent of focus surface, and updates the cursor if the cursor created by this when moves to different display. BUG= 804471 TEST=manual Change-Id: I8dc7a6fdc6f87c7b3872e54d7a61f43e2904b263 Reviewed-on: https://chromium-review.googlesource.com/882191 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532264}(cherry picked from commit 314513713e5fe647c2bfa8935550c94b7cc21391) Reviewed-on: https://chromium-review.googlesource.com/894709 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#191} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/fe85dae543740ea119d1115e2f2814977f535152/components/exo/pointer.cc [modify] https://crrev.com/fe85dae543740ea119d1115e2f2814977f535152/components/exo/wm_helper.cc [modify] https://crrev.com/fe85dae543740ea119d1115e2f2814977f535152/components/exo/wm_helper.h
,
Jan 31 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 24 2018