New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804452 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

"core.stacktrace_unittest.TabStackTraceTest.testValidDump" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 22 2018

Issue description

"core.stacktrace_unittest.TabStackTraceTest.testValidDump" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQwsSBUZsYWtlIjhjb3JlLnN0YWNrdHJhY2VfdW5pdHRlc3QuVGFiU3RhY2tUcmFjZVRlc3QudGVzdFZhbGlkRHVtcAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: kbr@chromium.org nedngu...@google.com perezju@chromium.org
 Issue 804450  has been merged into this issue.
Owner: nedngu...@google.com
Status: Assigned (was: Untriaged)
Cc: brucedaw...@chromium.org
Log:
CalledProcessError: Command '['e:\\b\\swarm_slave\\w\\ir\\out\\Release\\cdb\\cdb.exe', '-y', 'e:\\b\\swarm_slave\\w\\ir\\out\\Release', '-c', '.ecxr;.lastevent;kb30;~*kb30;q', '-z', 'e:\\b\\swarm_slave\\w\\itccayjd\\tmplattzp\\reports\\c64d0e5e-78ac-48cf-8dbf-9f60ff0d0d26.dmp']' returned non-zero exit status -1066598273


-1066598273 --> C06D007F

Bruce: do you know what would code C06D007F mean?

Comment 4 by kbr@chromium.org, Jan 22 2018

Components: Tests>Telemetry
From a separate email thread:

test-results does seem to know about it on win7_chromium_rel_ng:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=telemetry_perf_unittests&builder=tryserver.chromium.win%3Awin7_chromium_rel_ng

It's the second line down and it's failing most of the time.

We incorporate Microsoft's cdb.exe executable into the isolate. Unless we're missing a dependency – which is possible, if we upgraded our hermetic Windows SDK version recently (cc'ing brucedawson) – it should be able to run. See:

https://cs.chromium.org/chromium/src/build/win/copy_cdb_to_output.py?type=cs&q=cdb.exe&sq=package:chromium&l=52
https://cs.chromium.org/chromium/src/build/win/BUILD.gn?type=cs&q=cdb.exe&sq=package:chromium&l=24

We ought to be able to log on to one of the affected Windows bots, like vm434-m4 from:

https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/85216
https://chromium-swarm.appspot.com/task?id=3b2a4508bef9f210&refresh=10&show_raw=1

and try reproducing (or, better: clicking the "Debug" button on that shard).

Comment 5 by kbr@chromium.org, Jan 22 2018

Labels: OS-Windows
sheriff: disabling this test as <https://chromium-review.googlesource.com/c/chromium/src/+/881241>.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07bce4a6e7321e216e141bb34bff8d5d8d734a97

commit 07bce4a6e7321e216e141bb34bff8d5d8d734a97
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Jan 23 19:31:16 2018

sheriff: disable TabStackTraceTest.testValidDump

TBR=brucedawson@chromium.org

Bug:  804452 
Change-Id: I49e348b382ea3df249788b0d26c77b7b9f6afd45
Reviewed-on: https://chromium-review.googlesource.com/881241
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531300}
[modify] https://crrev.com/07bce4a6e7321e216e141bb34bff8d5d8d734a97/tools/perf/core/stacktrace_unittest.py

Comment 8 by joedow@chromium.org, Jan 23 2018

Labels: -Sheriff-Chromium
Removing sheriff label since the test disable patch has landed.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b91f674a20ce246aa646bb7ecabd217d113c5611

commit b91f674a20ce246aa646bb7ecabd217d113c5611
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Jan 26 23:53:13 2018

Add missing cdb dll, causing failures on win7 crash integration tests

(Link to working run on Win7 bot:
https://chromium-swarm.appspot.com/task?id=3b4d2229fcb0aa10&refresh=10&show_raw=1)

Bug:  805409 ,  804452 
Change-Id: Ieea7271856276162483e9a4240452701a1e062e7
Reviewed-on: https://chromium-review.googlesource.com/889701
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532094}
[modify] https://crrev.com/b91f674a20ce246aa646bb7ecabd217d113c5611/build/win/BUILD.gn
[modify] https://crrev.com/b91f674a20ce246aa646bb7ecabd217d113c5611/build/win/copy_cdb_to_output.py

Cc: scottmg@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8768b91742fee475c248ce8346b97ed641de52a4

commit 8768b91742fee475c248ce8346b97ed641de52a4
Author: Ned Nguyen <nednguyen@google.com>
Date: Sat Jan 27 09:35:23 2018

Revert "sheriff: disable TabStackTraceTest.testValidDump"

This reverts commit 07bce4a6e7321e216e141bb34bff8d5d8d734a97.

Reason for revert: scottmg@'s may fix this in https://chromium-review.googlesource.com/889701

Original change's description:
> sheriff: disable TabStackTraceTest.testValidDump
> 
> TBR=brucedawson@chromium.org
> 
> Bug:  804452 
> Change-Id: I49e348b382ea3df249788b0d26c77b7b9f6afd45
> Reviewed-on: https://chromium-review.googlesource.com/881241
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531300}

TBR=ellyjones@chromium.org,nednguyen@google.com,brucedawson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  804452 
Change-Id: Ie24f2780f0430232e62eccc54d610ccda8c9e8e2
Reviewed-on: https://chromium-review.googlesource.com/890023
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#532209}
[modify] https://crrev.com/8768b91742fee475c248ce8346b97ed641de52a4/tools/perf/core/stacktrace_unittest.py

Owner: scottmg@chromium.org
Status: Fixed (was: Assigned)
Looks like it was scottmg@'s patch that fixed this.

Sign in to add a comment