Fix IconDipSize errors |
|||
Issue description
1. Remove <ignore regexp="chrome/android/java/res/.*tab_strip_fade"/> from build/android/lint/suppressions.xml
2. Build chrome_java
3. Fix resulting errors
chrome/android/java/res/drawable-xxhdpi/tab_strip_fade.png The image `tab_strip_fade.png` varies significantly in its density-independent (dip) size across the various density versions: drawable-hdpi/tab_strip_fade.png: 24x1 dp (36x1 px), drawable-mdpi/tab_strip_fade.png: 24x1 dp (24x1 px), drawable-xhdpi/tab_strip_fade.png: 24x1 dp (48x1 px), drawable-xxhdpi/tab_strip_fade.png: 24x0 dp (72x1 px), drawable-xxxhdpi/tab_strip_fade.png: 24x0 dp (96x1 px): IconDipSize [warning]
chrome/android/java/res/drawable-xxxhdpi/tab_strip_fade_for_model_selector.png The image `tab_strip_fade_for_model_selector.png` varies significantly in its density-independent
(dip) size across the various density versions: drawable-hdpi/tab_strip_fade_for_model_selector.png: 64x1 dp (96x1 px), drawable-mdpi/tab_strip_fade_for_model_selector.png: 64x1
dp (64x1 px), drawable-xhdpi/tab_strip_fade_for_model_selector.png: 64x1 dp (128x1 px), drawable-xxhdpi/tab_strip_fade_for_model_selector.png: 64x0 dp (192x1 px), drawable-xxxhdpi/tab_strip_fade_for_model_selector.png: 64x0 dp (256x1 px): IconDipSize [warning]
,
Jan 22 2018
Sounds good, I'll fix the comment when I update suppressions.xml.
,
Jan 22 2018
,
Jan 22 2018
Looks like these were already all 1px, but we did have a bug many, many moons ago where some old tablets were crashing because they used an odd combination of scaling factors to take a 1px asset and scale it down to zero causing crashes. We've likely broken this a long time ago, but maybe just an hilarious bit of lore.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3955da70d67e9e6018208b9f7f89f92d803cfe40 commit 3955da70d67e9e6018208b9f7f89f92d803cfe40 Author: Peter Wen <wnwen@chromium.org> Date: Wed Jan 24 18:42:31 2018 Android: Update suppressions and fix NewApi Now that separate bugs have been filed to fix lint suppressions the code should be updated accordingly. Unforunately the NewApi suppression was wrongly added and allowed a whole bunch of failures into the codebase in a matter of days. Fixing that in this CL. BUG= 799070 , 804449 , 804438 , 805509 TBR=bauerb@chromium.org,michaelbai@chromium.org Change-Id: I22222837a70da3680a5968e7e002862ecdf12d04 Reviewed-on: https://chromium-review.googlesource.com/884004 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531622} [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/build/android/lint/suppressions.xml [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/tools/android/memconsumer/java/AndroidManifest.xml |
|||
►
Sign in to add a comment |
|||
Comment 1 by twelling...@chromium.org
, Jan 22 2018