Need an Android equivalent of UkmBrowserTest metrics consent tests. https://cs.chromium.org/chromium/src/chrome/browser/metrics/ukm_browsertest.cc?rcl=ec6164f0fef97b790f8a0c2da5b1526cf3ff9673&l=497 UkmBrowserTest, MetricsConsentCheck UkmBrowserTest, ConsentAddedButNoSyncCheck Should be similar to existing Android UKM integration test: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/UkmIncognitoTest.java?rcl=d74544f69ecbcfa29f2587e1ff63daddd0e6e490&l=52 These tests will need some other way to set up Sync instead of using --force-enable-metrics-reporting (similar to crbug/804445)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5960d4dba6c6d79acc1add57bf15d88ac0cc06a commit e5960d4dba6c6d79acc1add57bf15d88ac0cc06a Author: Robert Kaplow <rkaplow@chromium.org> Date: Fri Mar 23 01:23:50 2018 Android browsertests for UKM sync. I tried to refactor the logic in UkmIncognitoTest (especially getElementContent), but couldn't find a clean way to do it that didn't add a good amount of complexity (mainly because UkmTest is in the sync_shell target). Since it was only a couple lines I thought using comments to signal changes would be alright to avoid the extra dependencies. Bug: 804448 Change-Id: I0aeeab14341e2525a32064be809b50f76b9c8566 Reviewed-on: https://chromium-review.googlesource.com/974542 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#545326} [modify] https://crrev.com/e5960d4dba6c6d79acc1add57bf15d88ac0cc06a/chrome/android/BUILD.gn [modify] https://crrev.com/e5960d4dba6c6d79acc1add57bf15d88ac0cc06a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java [modify] https://crrev.com/e5960d4dba6c6d79acc1add57bf15d88ac0cc06a/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/UkmIncognitoTest.java [add] https://crrev.com/e5960d4dba6c6d79acc1add57bf15d88ac0cc06a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/UkmTest.java [modify] https://crrev.com/e5960d4dba6c6d79acc1add57bf15d88ac0cc06a/chrome/browser/android/metrics/uma_session_stats.cc [modify] https://crrev.com/e5960d4dba6c6d79acc1add57bf15d88ac0cc06a/chrome/browser/metrics/ukm_browsertest.cc
Comment 1 by rkaplow@chromium.org
, Feb 1 2018