Issue 804445 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Mar 2018
Cc:	skare@chromium.org isherman@chromium.org asvitk...@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics>UKM
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug

Need an Android equivalent of UkmBrowserTest sync state tests.

Project Member Reported by holte@chromium.org, Jan 22 2018

Issue description

Need an Android equivalent of UkmBrowserTest sync state tests.
https://cs.chromium.org/chromium/src/chrome/browser/metrics/ukm_browsertest.cc?rcl=ec6164f0fef97b790f8a0c2da5b1526cf3ff9673&l=497

UkmBrowserTest, SingleDisableSyncCheck
UkmBrowserTest, SecondaryPassphraseCheck
UkmBrowserTest, SingleSyncSignoutCheck

(multi-profile tests should not be needed on Android)

Should be similar to existing Android UKM integration test:
https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/UkmIncognitoTest.java?rcl=d74544f69ecbcfa29f2587e1ff63daddd0e6e490&l=52

These tests will need some other way to set up Sync instead of using --force-enable-metrics-reporting

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/736d4d99c22c1ebc747e1b40c1d77bbcd8deaea9

commit 736d4d99c22c1ebc747e1b40c1d77bbcd8deaea9
Author: Robert Kaplow <rkaplow@chromium.org>
Date: Tue Mar 27 22:51:24 2018

Add more sync tests from ukm_browsertest to Android

Bug:  804445 
Change-Id: I031b2e178984709042f73c49e08801a33ebd088d
Reviewed-on: https://chromium-review.googlesource.com/980743
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546301}
[modify] https://crrev.com/736d4d99c22c1ebc747e1b40c1d77bbcd8deaea9/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
[modify] https://crrev.com/736d4d99c22c1ebc747e1b40c1d77bbcd8deaea9/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestRule.java
[modify] https://crrev.com/736d4d99c22c1ebc747e1b40c1d77bbcd8deaea9/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/UkmTest.java
[modify] https://crrev.com/736d4d99c22c1ebc747e1b40c1d77bbcd8deaea9/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/736d4d99c22c1ebc747e1b40c1d77bbcd8deaea9/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java

Comment 2 by rkaplow@google.com, Mar 28 2018

Status: Fixed (was: Available)

►

Issue 804445 link

Issue metadata

Need an Android equivalent of UkmBrowserTest sync state tests.

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

Comment 1 Deleted

Comment 2 by rkaplow@google.com, Mar 28 2018

Comment 2 Deleted

Sign in to add a comment