MetricsServiceAccessor does not respect --force-enable-metrics-reporting |
|
Issue descriptionChromeMetricsServiceClient::IsMetricsReportingForceEnabled() uses the command line switch force-enable-metrics-reporting This command line ends up affecting MetricsServicesManager. https://cs.chromium.org/chromium/src/components/metrics_services_manager/metrics_services_manager.cc?type=cs&sq=package:chromium&l=158-159 However, the command line does not get used in MetricsServiceAccessor::IsMetricsReportingEnabled() https://cs.chromium.org/chromium/src/components/metrics/metrics_service_accessor.cc?type=cs&sq=package:chromium&l=16-30 This seems inconsistent. There might be background on this that I don't know about, so I'm not fixing it myself. Assigning to (For background, this came up in the context of https://chromium-review.googlesource.com/c/chromium/src/+/865154 which needs to force MetricsServiceAccessor, in tests, to believe metrics reporting is enabled. The author of that changelist did something to get around this; I did not block that changelist on this bug. Nonetheless, probably something should be done here to clean this up.) |
|
►
Sign in to add a comment |
|