New issue
Advanced search Search tips

Issue 804441 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix AppLinkUrlError

Project Member Reported by wnwen@chromium.org, Jan 22 2018 
1. Remove <issue id="AppLinkUrlError"> in build/android/lint/suppressions.xml
2. Build all, fix resulting errors in remoting AndroidManifest.xml

@Yuwei - Can you fix this for android remoting?

Comment 1 by yuweih@chromium.org, Jan 22 2018

Components: Services>Chromoting
Working on this..

Comment 2 by wnwen@chromium.org, Jan 24 2018 

Thank you for working on this!
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb64eb38a995408eeb6ae04673a11998e0daa617

commit eb64eb38a995408eeb6ae04673a11998e0daa617
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Jan 26 22:07:06 2018

[Remoting Android] Fix AppLinkUrlError

This CL adds android:host="*" to the intent filter and removes the
AppLinkUrlError suppression.

Bug:  804441 
Change-Id: I30dc3f0171fbfb6b4f195b90f7deba0fd43911ba
Reviewed-on: https://chromium-review.googlesource.com/879584
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532071}
[modify] https://crrev.com/eb64eb38a995408eeb6ae04673a11998e0daa617/build/android/lint/suppressions.xml
[modify] https://crrev.com/eb64eb38a995408eeb6ae04673a11998e0daa617/remoting/android/java/AndroidManifest.xml.jinja2

Comment 4 by yuweih@chromium.org, Jan 26 2018

Status: Fixed (was: Assigned)

Comment 5 by wnwen@chromium.org, Jan 29 2018 

Good job! Thank you for fixing this issue so that all future AppLinkUrlErrors will show up for AndroidManifest files!
►

Sign in to add a comment