New issue
Advanced search Search tips

Issue 804438 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Use android.support.media.ExifInterface instead of android.media.ExifInterface

Project Member Reported by wnwen@chromium.org, Jan 22 2018

Issue description

android.media.ExifInterface is deprecated, we should use android.support.media.ExifInterface instead for chrome/android/java/src/org/chromium/chrome/browser/photo_picker/BitmapUtils.java

Remove <issue id="ExifInterface"> in build/android/lint/suppressions.xml after migration.

@Finnur - Unfortunately the new one does not have a constructor for ExifInterface(FileDescriptor), is there any way for us to migrate to it?

Deprecated: https://developer.android.com/reference/android/media/ExifInterface.html
https://developer.android.com/reference/android/support/media/ExifInterface.html
 

Comment 1 by finnur@chromium.org, Jan 23 2018

The use of the FileDescriptors is essential to securely and efficiently pass the data between processes. I don't see a good way of migrating unless the new API supports FileDescriptors.

Comment 2 by wnwen@chromium.org, Jan 24 2018

Status: WontFix (was: Assigned)
Oh well, I'll update the suppression with this bug as reference since it looks like it's here to stay.

Thanks for confirming!
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3955da70d67e9e6018208b9f7f89f92d803cfe40

commit 3955da70d67e9e6018208b9f7f89f92d803cfe40
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 24 18:42:31 2018

Android: Update suppressions and fix NewApi

Now that separate bugs have been filed to fix lint suppressions the code
should be updated accordingly.

Unforunately the NewApi suppression was wrongly added and allowed a
whole bunch of failures into the codebase in a matter of days. Fixing
that in this CL.

BUG= 799070 , 804449 , 804438 , 805509 
TBR=bauerb@chromium.org,michaelbai@chromium.org

Change-Id: I22222837a70da3680a5968e7e002862ecdf12d04
Reviewed-on: https://chromium-review.googlesource.com/884004
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531622}
[modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/build/android/lint/suppressions.xml
[modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
[modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/tools/android/memconsumer/java/AndroidManifest.xml

Sign in to add a comment