New issue
Advanced search Search tips

Issue 804432 link

Starred by 0 users
Status: Available
Owner: ----
Cc:
twelling...@chromium.org
tedc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix EllipsizeMaxLines lint error

Project Member Reported by wnwen@chromium.org, Jan 22 2018 
Root cause for adding this lint error: http://b/36950033

Message: Combining `ellipsize=marquee` and `maxLines=1` can lead to crashes. Use `singleLine=true` instead.

Explanation: Combining `ellipsize` and `maxLines=1` can lead to crashes on some devices. Earlier versions of lint recommended replacing `singleLine=true` with `maxLines=1` but that should not be done when using `ellipsize`.

1. Remove <issue id="EllipsizeMaxLines" severity="ignore"/> from build/android/lint/suppressions.xml
2. Fix resulting lint errors

@Theresa - Would you mind triaging this to UI/UX folks? Thanks, I tried fixing these but didn't want to introduce UX regressions that I don't understand.

Comment 1 by twelling...@chromium.org, Jan 22 2018

Cc: tedc...@chromium.org
Components: UI>Browser
Status: Available (was: Assigned)
It looks like this affects a fair number of XML files. It's probably a rather mechanical replacement, but we'll have to check at least a few of the screens to make sure things look correct.

+tedchoc@ - This would be a good bug to add to whatever triage queue/rotation we have for fixing bugs that could be owned by anyone on the Clank UI team.

Comment 2 by wnwen@chromium.org, Jan 22 2018 

I have a couple other bugs that could be filed for this UI triage queue/rotation.

Comment 3 by twelling...@chromium.org, Feb 6 2018

Cc: twelling...@chromium.org
Components: -UI>Browser UI>Browser>Mobile
Labels: android-fe-triaged
Owner: ----
Removing owner and adding android-fe-triaged label per front-end triage process.
►

Sign in to add a comment