TcpSocketProxyTest.DisconnectServer and DisconnectClient are disabled on iOS |
||||||||
Issue descriptionI've noticed a lot of net_unittests timeouts on the ios-simulator bot lately. I don't have an exact regression range, but it seems as though this started on Friday January 19. There's nothing obvious in the logs; the output just stops between tests, but always in the same place: [----------] 2 tests from SpdyMemSliceTest [ RUN ] SpdyMemSliceTest.MoveConstruct [ OK ] SpdyMemSliceTest.MoveConstruct (0 ms) [ RUN ] SpdyMemSliceTest.MoveAssign [ OK ] SpdyMemSliceTest.MoveAssign (0 ms) [----------] 2 tests from SpdyMemSliceTest (2 ms total) [----------] 8 tests from SpdyStringUtilsTest [ RUN ] SpdyStringUtilsTest.SpdyStrCat [ OK ] SpdyStringUtilsTest.SpdyStrCat (1 ms) https://ci.chromium.org/buildbot/chromium.mac/ios-simulator/?limit=200 will show a list of recent failures. https://chromium-swarm.appspot.com/task?id=3b380063fa2c3510&refresh=10&show_raw=1 contains logs from one specific failure.
,
Jan 22 2018
Sorry, the duration of the individual tests is actually printed. I will try to compare successful and unsuccessful runs.
,
Jan 22 2018
,
Jan 22 2018
I wrote a simple script to sum up the duration of individual net_unittests for successful and timed-out runs. For a successful run it printed: Count: 20267, duration: 274920 ms , which is close to the bot output: [==========] 20267 tests from 683 test cases ran. (303391 ms total) [ PASSED ] 20267 tests. For a timed out case, the script printed: Count: 5260, duration: 69763 ms The tests definitely didn't take 22m 15s as reported by the bot: https://chromium-swarm.appspot.com/task?id=3b3858b10de31e10&refresh=10&show_raw=1 Is it possible that something else takes long time before the tests are actually started? I have also noticed that other test groups started to time out too, e.g. url_unittest and ios_chrome_unittests. It looks like an infrastructure issue. Adding the Infra team to take a look.
,
Jan 22 2018
In the timedout case, the test ran for 70s, and then it hung. After 20 minutes of no log output, swarming automatically killed the test. The root issue is that the tests are hanging for some reason, but I don't know why.
,
Jan 22 2018
I have one run locally that's stuck in read_callback.GetResult():
void ExpectClosed(StreamSocket* socket) {
scoped_refptr<IOBufferWithSize> read_buffer(new IOBufferWithSize(1024));
TestCompletionCallback read_callback;
int read_result = socket->Read(read_buffer.get(), read_buffer->size(),
read_callback.callback());
EXPECT_EQ(read_callback.GetResult(read_result), 0);
EXPECT_FALSE(socket->IsConnected());
}
[----------] 5 tests from TcpSocketProxyTest
[ RUN ] TcpSocketProxyTest.SendAndReceive
[ OK ] TcpSocketProxyTest.SendAndReceive (3 ms)
[ RUN ] TcpSocketProxyTest.TwoConnections
[ OK ] TcpSocketProxyTest.TwoConnections (3 ms)
[ RUN ] TcpSocketProxyTest.DisconnectServer
,
Jan 22 2018
[sergeyu]: You added TcpSocketProxyTest.DisconnectServer. Mind taking a look?
,
Jan 22 2018
Chatting with sergeyu now, and it sounds like this test was not running on iOS until Friday. So it seems likely that this test has always been broken on iOS, but wasn't running until recently. I'd like to write a CL that disables these tests on iOS.
,
Jan 22 2018
Not sure if related, but here net_unittests fails on Android as well: https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/472760 Comparing with a successful run, a whole 256 tests shard timed out. Anyone of these: Google Test filter = MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/130:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/133:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/135:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/139:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/143:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/145:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/146:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/148:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/151:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/152:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/157:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/158:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/160:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/163:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/166:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/17:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/172:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/175:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/178:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/180:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/185:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/186:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/189:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/19:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/190:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/197:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/200:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/207:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/210:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/215:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/216:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/219:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/22:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/220:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/223:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/24:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/27:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/28:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/30:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/33:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/36:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/40:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/45:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/46:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/49:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/5:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/51:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/52:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/57:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/58:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/6:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/60:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/63:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/66:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/70:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/73:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/75:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/79:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/80:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/87:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/90:MimeSnifferPlainTextTestNotControlCodeRange/MimeSnifferPlainTextTest.NotBinaryControlCode/97:MimeSnifferPlainTextTestPlainTextControlCodes/MimeSnifferPlainTextTest.NotBinaryControlCode/3:MimeSnifferPlainTextTestPlainTextControlCodes/MimeSnifferPlainTextTest.NotBinaryControlCode/4:MimeSnifferTest.AudioVideoTest:MimeSnifferTest.BasicSniffingTest:MimeSnifferTest.ChromeExtensionsTest:MimeSnifferTest.DontAllowPrivilegeEscalationTest:MimeSnifferTest.OfficeTest:MimeSnifferTest.UnicodeTest:MimeSnifferTest.XMLTest:MimeSnifferTest.XMLTestLargeNoAngledBracket:MimeUtilTest.MatchesMimeType:MimeUtilTest.TestAddMultipartValueForUpload:MimeUtilTest.TestGenerateMimeMultipartBoundary:MimeUtilTest.TestGetExtensionsForMimeType:MimeUtilTest.TestParseMimeTypeWithoutParameter:MojoHostResolverImplTest.ResolveFailure:MojoHostResolverImplTest.ResolveMultiple:MojoProxyResolverV8TracingBindingsTest.Basic:MoreTests/QuicCryptoServerStreamTestWithFailingProofSource.Test/0:MultiLogCTVerifierTest.CountsValidSCTsInStatusHistogram:MultiLogCTVerifierTest.CountsZeroSCTsCorrectly:MultiLogCTVerifierTest.VerifiesEmbeddedSCT:MultiLogCTVerifierTest.VerifiesEmbeddedSCTWithIntermediateAndPreCA:MultiThreadedCertVerifierTest.CancelRequestThenQuit:MultiThreadedCertVerifierTest.InflightJoin:MultiThreadedProxyResolverTest.CancelCreate:MultiThreadedProxyResolverTest.DeleteRequestInFactoryCallback:MultiThreadedProxyResolverTest.DestroyFactoryWithRequestsInProgress:MultiThreadedProxyResolverTest.SingleThread_UpdatesNetLogWithThreadWait:NetLogCaptureMode.DefaultConstructor:NetLogCaptureMode.IncludeSocketBytes:NetLogTest.NetLogEventThreads:NetLogUtil.CreateNetLogEntriesForActiveObjectsOneContext:NetLogUtil.GetNetInfo:NetStringUtilTest.ToUpperAlreadyUpper:NetStringUtilTest.ToUpperSimple:NetStringUtilTest.ToUpperSingleChar:NetUtilTest.SetExplicitlyAllowedPortsTest:NetworkActivityMontiorTest.Threading:NetworkChangeNotifierAndroidTest.MaxBandwidth:NetworkChangeNotifierAndroidTest.NotificationsSentToClientsOfNetworkChangeNotifier:NetworkChangeNotifierAndroidTest.NotificationsSentToNetworkChangeNotifierAndroid:NetworkChangeNotifierTest.IgnoreAirdropOnMac:NetworkChangeNotifierTest.IgnoreTeredoOnWindows:NetworkChangeNotifierTest.IgnoreVMInterfaces:NetworkChangeNotifierTest.NetMaxBandwidthRange:NetworkConnectionTest.Connection2G:NetworkConnectionTest.ConnectionEthnernet:NetworkErrorLoggingEndToEndTest.ReportNetworkError:NetworkErrorLoggingEndToEndTest.UploadAtShutdown:NetworkErrorLoggingServiceTest.ExcludeSubdomainsDoesntMatchSubdomain:NetworkErrorLoggingServiceTest.NoPolicyForOrigin:NetworkErrorLoggingServiceTest.RemoveSomeBrowsingData:NetworkErrorLoggingServiceTest.ReportQueued:NetworkInterfacesTest.GetNetworkList:NetworkLibraryTest.CaptivePortal:NetworkQualityEstimatorParamsTest.TypicalNetworkQualities:NetworkQualityEstimatorTest.Caching:NetworkQualityEstimatorTest.DefaultObservations:NetworkQualityEstimatorTest.HangingRequestUsingHttpOnly:NetworkQualityEstimatorTest.MaybeComputeECTAfterNSamples:NetworkQualityEstimatorTest.ObservationDiscardedIfCachedEstimateAvailable:NetworkQualityEstimatorTest.ObtainThresholdsHttpRTTandThroughput:NetworkQualityEstimatorTest.Offline:NetworkQualityEstimatorTest.StoreObservations:NetworkQualityEstimatorTest.TestBDPComputation:NetworkQualityEstimatorTest.TestComputeIncreaseInTransportRTTFullHostsOverlap:NetworkQualityEstimatorTest.TestComputeIncreaseInTransportRTTPartialHostsOverlap:NetworkQualityEstimatorTest.TestExternalEstimateProvider:NetworkQualityEstimatorTest.TestKbpsRTTUpdates:NetworkQualityEstimatorTest.TestRTTAndThroughputEstimatesObserver:NetworkQualityEstimatorTest.TestRttThroughputObservers:NetworkQualityEstimatorTest.UnknownEffectiveConnectionType:NetworkQualityEstimatorUtilTest.ReservedHostUncached:NetworkQualityObservationBufferTest.PercentileDifferentTimestamps:NetworkQualityObservationBufferTest.RemoveObservations:NetworkQualityObservationBufferTest.RestGetPercentileForEachRemoteHostComputation:NetworkQualitySocketWatcherTest.NotificationsThrottled:NetworkQualitySocketWatcherTest.QuicFirstNotificationDropped:NetworkQualitySocketWatcherTest.RemoteHostIPHashComputedCorrectly:NetworkQualityStoreTest.TestCaching:NetworkQualityStoreTest.TestCachingClosestSignalStrength:NetworkThrottleManagerTest.IgnoreLimits:NoHandler/HpackDecoderAdapterTest.AddHeaderDataWithHandleControlFrameHeadersData/0:NoHandler/HpackDecoderAdapterTest.BasicC31/0:NoHandler/HpackDecoderAdapterTest.ContextUpdateMaximumSize/2:NoHandler/HpackDecoderAdapterTest.Cookies/3:NoHandler/HpackDecoderAdapterTest.DecodeWithIncompleteData/1:NoHandler/HpackDecoderAdapterTest.DecodeWithIncompleteData/2:NoHandler/HpackDecoderAdapterTest.HandleHeaderRepresentation/0:NoHandler/HpackDecoderAdapterTest.HandleHeaderRepresentation/3:NoHandler/HpackDecoderAdapterTest.HeaderTooLongToBuffer/3:NoHandler/HpackDecoderAdapterTest.HuffmanEOSError/2:NoHandler/HpackDecoderAdapterTest.IndexedHeaderDynamic/0:NoHandler/HpackDecoderAdapterTest.IndexedHeaderDynamic/3:NoHandler/HpackDecoderAdapterTest.IndexedHeaderStatic/1:NoHandler/HpackDecoderAdapterTest.IndexedHeaderStatic/2:NoHandler/HpackDecoderAdapterTest.InvalidIndexedHeader/0:NoHandler/HpackDecoderAdapterTest.InvalidIndexedHeader/3:NoHandler/HpackDecoderAdapterTest.LiteralHeaderIncrementalIndexing/1:NoHandler/HpackDecoderAdapterTest.LiteralHeaderIncrementalIndexing/2:NoHandler/HpackDecoderAdapterTest.LiteralHeaderNeverIndexedInvalidNameIndex/1:NoHandler/HpackDecoderAdapterTest.LiteralHeaderNeverIndexedInvalidNameIndex/2:NoHandler/HpackDecoderAdapterTest.LiteralHeaderNoIndexing/0:NoHandler/HpackDecoderAdapterTest.LiteralHeaderNoIndexing/3:NoHandler/HpackDecoderAdapterTest.LiteralHeaderNoIndexingInvalidNameIndex/2:NoHandler/HpackDecoderAdapterTest.LiteralHeaderWithIndexingInvalidNameIndex/2:NoHandler/HpackDecoderAdapterTest.NameTooLong/1:NoHandler/HpackDecoderAdapterTest.ReuseNameOfEvictedEntry/3:NoHandler/HpackDecoderAdapterTest.SectionC4RequestHuffmanExamples/2:NoHandler/HpackDecoderAdapterTest.SectionC6ResponseHuffmanExamples/2:NoHandler/HpackDecoderAdapterTest.TableSizeUpdateFirstThirdError/2:NoHandler/HpackDecoderAdapterTest.TableSizeUpdateSecondError/0:NoHandler/HpackDecoderAdapterTest.TableSizeUpdateSecondError/3:NoHandler/HpackDecoderAdapterTest.ThreeTableSizeUpdatesError/1:NoHandler/HpackDecoderAdapterTest.ThreeTableSizeUpdatesError/2:NoHandler/HpackDecoderAdapterTest.TruncatedHuffmanLiteral/1:NoHandler/HpackDecoderAdapterTest.TruncatedHuffmanLiteral/2:NoHandler/HpackDecoderAdapterTest.TruncatedIndex/0:NoHandler/HpackDecoderAdapterTest.TruncatedIndex/3:NoHandler/HpackDecoderAdapterTest.TwoTableSizeUpdates/1:NoHandler/HpackDecoderAdapterTest.TwoTableSizeUpdates/2:NtlmBufferReaderTest.EmptyBuffer:NtlmBufferReaderTest.MatchEmptySecurityBufferLengthZeroOffsetEnd:NtlmBufferReaderTest.MatchMessageTypeAuthenticate:NtlmBufferReaderTest.MatchMessageTypeInvalid:NtlmBufferReaderTest.MatchSignatureNoMatch:NtlmBufferReaderTest.MatchSignatureOk:NtlmBufferReaderTest.MatchZeros:NtlmBufferReaderTest.Read32:NtlmBufferReaderTest.ReadAvPairHeader:NtlmBufferReaderTest.ReadAvPairHeaderPastEob:NtlmBufferReaderTest.ReadBytes:NtlmBufferReaderTest.ReadMessageTypeChallenge:NtlmBufferReaderTest.ReadPayloadBadLength:NtlmBufferReaderTest.ReadPayloadBadOffset:NtlmBufferReaderTest.ReadTargetInfoEmpty:NtlmBufferReaderTest.ReadTargetInfoEmptyPayload:NtlmBufferReaderTest.ReadTargetInfoFlagsAndEolOnly:NtlmBufferReaderTest.ReadTargetInfoInvalidTimestampPastEob:NtlmBufferReaderTest.ReadTargetInfoInvalidTimestampSize:NtlmBufferReaderTest.ReadTargetInfoTerminatorNonZeroLength:NtlmBufferReaderTest.SkipBytes:NtlmBufferReaderTest.SkipBytesPastEob:NtlmBufferReaderTest.SkipSecurityBufferWithValidationPayloadLengthPastEob:NtlmBufferReaderTest.SkipSecurityBufferWithValidationValid:NtlmBufferWriterTest.Write16:NtlmBufferWriterTest.Write16PastEob:NtlmBufferWriterTest.Write32PastEob:NtlmBufferWriterTest.Write64:NtlmBufferWriterTest.WriteAvPairHeader:NtlmBufferWriterTest.WriteNarrowString:NtlmBufferWriterTest.WriteSignaturePastEob:NtlmBufferWriterTest.WriteUtf8AsUtf16String:NtlmClientTest.ChallengeMsgNoSig:NtlmClientTest.Type3WithoutUnicode:NtlmClientTest.VerifyAuthenticateMessageV2:NtlmClientTest.VerifyNegotiateMessageV2:NtlmTest.GenerateChannelBindingHashV2SpecTests:NtlmTest.GenerateMicSpecResponseV2:NtlmTest.GenerateNtlmHashV1PasswordChangesHash:NtlmTest.GenerateNtlmProofV2:NtlmTest.GenerateUpdatedTargetInfo:NtlmTest.GenerateUpdatedTargetInfoNoEpaOrMic:NtlmTest.GenerateUpdatedTargetInfoWhenServerSendsNoTargetInfo:NtlmTest.GenerateUpdatedTargetInfoWithServerTimestamp:NtlmTest.MapHashToDesKeysAllZeros:NullDecrypterTest.BadHash:NullEncrypterTest.EncryptClientPre37:NullEncrypterTest.GetCiphertextSize:OCSPDateTest.NextUpdatePassed:OCSPDateTest.ThisUpdateInTheFuture:OCSPDateTest.VerifyTimeMinusAgeFromBeforeWindowsEpoch:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/14:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/2:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/21:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/26:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/5:OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/8:P256KeyExchangeTest.SharedKey:PEMTokenizerTest.BlockWithHeader:PEMTokenizerTest.MissingFooter:PEMTokenizerTest.MultipleAcceptedBlockTypes:PacingSenderTest.SendNow:PacketNumberIndexedQueueTest.ConstGetter:PacketNumberIndexedQueueTest.InsertingContinuousElements:PacketNumberIndexedQueueTest.InsertingDuplicate:PacketNumberIndexedQueueTest.RemoveAtDistantBack:PacketNumberIndexedQueueTest.RemoveAtDistantFront:PacketNumberQueueTest.AddRange:PacketNumberQueueTest.IntervalLengthAndRemoveInterval
,
Jan 22 2018
I don't see TcpSocketProxyTest in that list, so I think the android timeouts are unrelated?
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77cc1c93b7b9cbcbe65044cf1739e0872f3d471a commit 77cc1c93b7b9cbcbe65044cf1739e0872f3d471a Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Jan 23 19:46:31 2018 Disables TcpSocketProxyTest.DisconnectServer and DisconnectClient on iOS These tests were originally only run when the remote test server was in use, but that restriction was relaxed in https://chromium-review.googlesource.com/c/chromium/src/+/858289. The tests hang when run on iOS, so this CL disables them. BUG= 804429 Change-Id: I73cabb162ffd9439b367793d003c0df00f1011af Reviewed-on: https://chromium-review.googlesource.com/879682 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#531307} [modify] https://crrev.com/77cc1c93b7b9cbcbe65044cf1739e0872f3d471a/net/test/tcp_socket_proxy_unittest.cc
,
Jan 24 2018
The offending tests are now disabled on iOS. Repurposing this bug to track fixing and re-enabling the tests.
,
Feb 14 2018
[+kapishnikov]: Do we care about these tests on iOS? If not, we can probably just WontFix this, since they're testing test code not used on iOS.
,
Feb 14 2018
,
Feb 14 2018
Since the code under the test is not used on iOS, I vote for WontFix. I don't think that the test failure is a regression since the tests haven't been run on iOS before. They have been added to the net_unittest recently by https://chromium-review.googlesource.com/c/chromium/src/+/858289.
,
Feb 14 2018
It is a bit weird that the tests have no platform dependencies, pass on Mac, and yet are failing on iOS, but I'm fine with closing it. But let's go ahead and close it. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kapishnikov@chromium.org
, Jan 22 2018