ColescePendingMotionEvents includes mouse wheel events. |
|||||
Issue descriptionIt happens sometimes that ColescePendingMotionEvents coalesces with mouse wheel events. Right after this call, EventTypeFromXEvent can return unknown type for an XEvent due to a successful call to DeviceDataManagerX11::GetInstance()->HasEventData(xievent, DeviceDataManagerX11::DT_CMT_SCROLL_X/Y) in Linux. Most probably that mustn't happen in Linux, See more discussion in https://crrev.com/c/853953
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46169bf03375205b6cf62cde0d68ff88c80ab14 commit e46169bf03375205b6cf62cde0d68ff88c80ab14 Author: Maksim Sisov <msisov@igalia.com> Date: Tue Jan 23 09:07:38 2018 Reland "Move and rename ConvertEventToDifferentHost to event_utils.h" This relands commit 53549f0a1c2, reverted by bfdecad144, due to https://crbug.com/794140 Added a check in desktop_window_tree_host_x11, which doesn't send a MouseEvents, when a type of events is UNKNOWN. Events' type can be resolved to UNKNOWN because of a bug in DeviceDataManagerX11, when an event takes a path meant for events from cmt devices, which doesn't seem to exist on Linux, but ChromeOs. Original message stated that this patch doesn't bring any functionality changes,but moves ConvertEventToDifferentHost to event_utils and makes it also available for ozone x11 builds, but actually it has revealed a bug with coalescing XEvents. Bug: 707406 , 794140, 804418 Change-Id: Ic57be5baad2e4d9fb0543ee1b0a83294aee470f6 Reviewed-on: https://chromium-review.googlesource.com/853953 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#531189} [modify] https://crrev.com/e46169bf03375205b6cf62cde0d68ff88c80ab14/ui/events/event_utils.cc [modify] https://crrev.com/e46169bf03375205b6cf62cde0d68ff88c80ab14/ui/events/event_utils.h [modify] https://crrev.com/e46169bf03375205b6cf62cde0d68ff88c80ab14/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc [modify] https://crrev.com/e46169bf03375205b6cf62cde0d68ff88c80ab14/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
,
Aug 1
,
Aug 17
doesn't seem to be an issue anymore. Closing |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by msi...@igalia.com
, Jan 23 2018