New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804415 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

gclient runhooks failing on chromium.gpu.fyi/Linux Release (AMD R7 240)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 22 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of weiliangc@google.com

gclient runhooks failing on chromium.gpu.fyi/Linux Release (AMD R7 240)

Builders failed on: 
- Linux Release (AMD R7 240): 
  https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R7%20240%29


Looks like failure is about not finding python dependency. Suspect this is related to revert from using vpython. 

 
Cc: -weiliangc@google.com weiliangc@chromium.org
Labels: Hotlist-PixelWrangler
Owner: no...@chromium.org
Failure log message:________ running '/usr/bin/python src/tools/perf/fetch_benchmark_deps.py -f' in '/b/c/b/Linux_Release__AMD_R7_240_'
Traceback (most recent call last):
  <module> at /b/c/b/Linux_Release__AMD_R7_240_/src/tools/perf/fetch_benchmark_deps.py:13
    from core import benchmark_finders
  <module> at /b/c/b/Linux_Release__AMD_R7_240_/src/tools/perf/core/benchmark_finders.py:10
    from core import perf_benchmark
  <module> at /b/c/b/Linux_Release__AMD_R7_240_/src/tools/perf/core/perf_benchmark.py:8
    from telemetry import benchmark
  <module> at /b/c/b/Linux_Release__AMD_R7_240_/src/third_party/catapult/telemetry/telemetry/benchmark.py:11
    from telemetry.internal import story_runner
  <module> at /b/c/b/Linux_Release__AMD_R7_240_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:14
    from py_utils import memory_debug  # pylint: disable=import-error
  <module> at /b/c/b/Linux_Release__AMD_R7_240_/src/third_party/catapult/common/py_utils/py_utils/memory_debug.py:9
    import psutil
ImportError: No module named psutil


Components: Internals>GPU>Testing Tests>Telemetry
Status: Assigned (was: Available)

Comment 3 by zmo@chromium.org, Jan 22 2018

Labels: Infra-Troopers
I ran into the same issue recently and by installing psutil the issue went away.
Cc: no...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Also there was no problem when vpython was on. catapult should use vpython so maybe there is some setup not working correctly there as well?

Marking this available so troopers can discover.

Comment 5 by kbr@chromium.org, Jan 22 2018

Components: Infra>Client>Chrome
Labels: -Pri-2 OS-Linux Pri-1 Type-Bug-Regression

Comment 6 by no...@chromium.org, Jan 22 2018

https://chromium-review.googlesource.com/c/chromium/src/+/877380 intended to revert vpython only for non-catapult deps. I didn't realize src/tools/perf/fetch_benchmark_deps.py is a part of catapult. I can enable vpython for that hook again. Is there anything else that is also catapult?
I don't exactly have a list of what is technically part of catapult, I would assume most of the src/tools/perf would ends up importing catapult?

Comment 8 by no...@chromium.org, Jan 22 2018

Cc: sullivan@chromium.org
sorry, i was under a wrong impression that you a speed team member. +sullivan
Cc: nedngu...@google.com
Ned, can you help triage?
Cc: kbr@chromium.org
Owner: d...@chromium.org
#4: catapult does use vpython on some other builders


kbr@ does this builder just need to be updated to use vpython?

Comment 11 by no...@chromium.org, Jan 22 2018

Owner: no...@chromium.org
Status: Assigned (was: Available)
Ned, see comment 6. Yes, it needs to be updated vpython. The question is which other deps are catapult too.

dnj@ has moved to another team, so unassigning him.
The two scripts that depend on catapult we put in gclient sync are:

third_party/catapult/telemetry/bin/fetch_telemetry_binary_dependencies
tools/perf/fetch_benchmark_deps

Comment 13 by no...@chromium.org, Jan 22 2018

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/879236
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eea875a37e7f44c7a243e2083311c11c0daaaa6c

commit eea875a37e7f44c7a243e2083311c11c0daaaa6c
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Jan 22 23:52:52 2018

[vpython] enable vpython for fetch_benchmark_deps.py

DEPS: run src/tools/perf/fetch_benchmark_deps.py via vpython
because it is a part of catapult which requires vpython

R=nednguyen@chromium.org

Bug:  804415 
Change-Id: Ie0080bb211144cbfa35df368d9e3998dac4a994a
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/879236
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#531066}
[modify] https://crrev.com/eea875a37e7f44c7a243e2083311c11c0daaaa6c/DEPS

Cc: robert...@chromium.org
 Issue 804609  has been merged into this issue.

Comment 16 by no...@chromium.org, Jan 23 2018

Status: Fixed (was: Started)
currently running Linux Release (AMD R7 240) build passed gclient runhooks
https://ci.chromium.org/buildbot/chromium.gpu.fyi/Linux%20Release%20%28AMD%20R7%20240%29/4062

Comment 17 by kbr@chromium.org, Jan 23 2018

Thanks Nodir.

Sign in to add a comment