"PasswordManagerBrowserTestBase.InternalsPage_Renderer" is flaky |
||||||||
Issue description"PasswordManagerBrowserTestBase.InternalsPage_Renderer" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQAsSBUZsYWtlIjVQYXNzd29yZE1hbmFnZXJCcm93c2VyVGVzdEJhc2UuSW50ZXJuYWxzUGFnZV9SZW5kZXJlcgw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs This flaky test/step was previously tracked in issue 803155 .
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb3f839eb89f0c0e9a1795b4ec9b7e7ebaa61101 commit bb3f839eb89f0c0e9a1795b4ec9b7e7ebaa61101 Author: Ned Nguyen <nednguyen@google.com> Date: Mon Jan 22 19:45:05 2018 Disable PasswordManagerBrowserTestBase.InternalsPage_Renderer TBR=vabr@chromium.org Bug: 804398 Change-Id: I6b1ae6a82ae65f2b30c9b604b7170c9445c82ff2 Reviewed-on: https://chromium-review.googlesource.com/879321 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#530955} [modify] https://crrev.com/bb3f839eb89f0c0e9a1795b4ec9b7e7ebaa61101/chrome/browser/password_manager/password_manager_browsertest.cc
,
Jan 23 2018
Findit found the flake started in build 42125 of the config "tryserver.chromium.linux / linux_chromium_asan_rel_ng" with confidence 62.1% based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKGAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzQyMTI1L2Jyb3dzZXJfdGVzdHMvVUdGemMzZHZjbVJOWVc1aFoyVnlRbkp2ZDNObGNsUmxjM1JDWVhObExrbHVkR1Z5Ym1Gc2MxQmhaMlZmVW1WdVpHVnlaWEk9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Flake Analyzer is in alpha version. Feedback is welcome using component Tools>Test>FindIt>Flakiness !
,
Jan 23 2018
Thanks for reporting and disabling the test. Looking at the logs on the bot, I don't see any related log message, only unsymbolised stack trace (pasted below just in case). I cannot reproduce locally (I did extensive checks when I marked the predecessor bug 803155 as fixed last week), but will be looking into symbolizing the trace on the bot first. BrowserTestBase received signal: Terminated. Backtrace: #0 0x000007c64f71 (/b/s/w/ir/out/Release/browser_tests+0x7c64f70) #1 0x0000134b3a4c (/b/s/w/ir/out/Release/browser_tests+0x134b3a4b) #2 0x000014bbe0b6 (/b/s/w/ir/out/Release/browser_tests+0x14bbe0b5) #3 0x7f1ca5787cb0 (/lib/x86_64-linux-gnu/libc-2.19.so+0x36caf) #4 0x7f1ca5841c9d (/lib/x86_64-linux-gnu/libc-2.19.so+0xf0c9c) #5 0x000007c61098 (/b/s/w/ir/out/Release/browser_tests+0x7c61097) #6 0x7f1cab721fe4 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0+0x48fe3) #7 0x7f1cab7220ec (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0+0x490eb) #8 0x000013555236 (/b/s/w/ir/out/Release/browser_tests+0x13555235) #9 0x000013543ac5 (/b/s/w/ir/out/Release/browser_tests+0x13543ac4) #10 0x0000135fad2b (/b/s/w/ir/out/Release/browser_tests+0x135fad2a) #11 0x000008ac5a31 (/b/s/w/ir/out/Release/browser_tests+0x8ac5a30) #12 0x000014bbd86c (/b/s/w/ir/out/Release/browser_tests+0x14bbd86b) #13 0x00001392562d (/b/s/w/ir/out/Release/browser_tests+0x1392562c) #14 0x0000139225a3 (/b/s/w/ir/out/Release/browser_tests+0x139225a2) #15 0x00000e0f4485 (/b/s/w/ir/out/Release/browser_tests+0xe0f4484) #16 0x00000f1ff208 (/b/s/w/ir/out/Release/browser_tests+0xf1ff207) #17 0x00000e0ef34b (/b/s/w/ir/out/Release/browser_tests+0xe0ef34a) #18 0x00000e0ff2ff (/b/s/w/ir/out/Release/browser_tests+0xe0ff2fe) #19 0x00000e0e7f0d (/b/s/w/ir/out/Release/browser_tests+0xe0e7f0c) #20 0x0000131ec0ac (/b/s/w/ir/out/Release/browser_tests+0x131ec0ab) #21 0x0000131ef10a (/b/s/w/ir/out/Release/browser_tests+0x131ef109) #22 0x00001a5d3786 (/b/s/w/ir/out/Release/browser_tests+0x1a5d3785) #23 0x0000131ea285 (/b/s/w/ir/out/Release/browser_tests+0x131ea284) #24 0x000014bbc67c (/b/s/w/ir/out/Release/browser_tests+0x14bbc67b) #25 0x0000137a69ba (/b/s/w/ir/out/Release/browser_tests+0x137a69b9) #26 0x00000b98888d (/b/s/w/ir/out/Release/browser_tests+0xb98888c) #27 0x00000b98a915 (/b/s/w/ir/out/Release/browser_tests+0xb98a914) #28 0x00000b98bcc7 (/b/s/w/ir/out/Release/browser_tests+0xb98bcc6) #29 0x00000b9a1dc7 (/b/s/w/ir/out/Release/browser_tests+0xb9a1dc6) #30 0x00000b9a12f9 (/b/s/w/ir/out/Release/browser_tests+0xb9a12f8) #31 0x0000137f4079 (/b/s/w/ir/out/Release/browser_tests+0x137f4078) #32 0x000013484dee (/b/s/w/ir/out/Release/browser_tests+0x13484ded) #33 0x000014cc46cf (/b/s/w/ir/out/Release/browser_tests+0x14cc46ce) #34 0x000013485bdc (/b/s/w/ir/out/Release/browser_tests+0x13485bdb) #35 0x000013484bac (/b/s/w/ir/out/Release/browser_tests+0x13484bab) #36 0x7f1ca5772f45 (/lib/x86_64-linux-gnu/libc-2.19.so+0x21f44) #37 0x000007c1a02a (/b/s/w/ir/out/Release/browser_tests+0x7c1a029)
,
Jan 23 2018
Just managed to reproduce this locally on a virtual Linux box with --gtest_repeat=250 --gtest_break_on_failure and symbolise the result (below). Still not sure about the cause, but having a hope to reproduce this helps.
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000003091f71 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:3867:13
#1 0x7f9a20e5bc1c in base::debug::StackTrace::StackTrace(unsigned long) /usr/local/google/home/vabr/chrome/src/out/asan/../../base/debug/stack_trace_posix.cc:808:41
#2 0x000009d73ac6 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) /usr/local/google/home/vabr/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:86:5
#3 0x7f99eeeea030 in killpg ??:?
#4 0x7f99eeeea030 in ?? ??:0
#5 0x7f99eef9663d in __poll ??:0:0
#6 0x00000308e098 in __interceptor_poll /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:3689:13
#7 0x7f99f28039f6 in g_main_context_poll ./debian/build/deb/glib/././glib/gmain.c:4228
#8 0x7f99f28039f6 in g_main_context_iterate ./debian/build/deb/glib/././glib/gmain.c:3924
#9 0x7f99f28039f6 in ?? ??:0
#10 0x7f99f2803b0c in g_main_context_iteration ??:0:0
#11 0x7f9a20f24d46 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) /usr/local/google/home/vabr/chrome/src/out/asan/../../base/message_loop/message_pump_glib.cc:305:30
#12 0x7f9a20f19195 in base::MessageLoop::Run(bool) /usr/local/google/home/vabr/chrome/src/out/asan/../../base/message_loop/message_loop.cc:350:12
#13 0x7f9a20fe1ddb in base::RunLoop::Run() /usr/local/google/home/vabr/chrome/src/out/asan/../../base/run_loop.cc:130:14
#14 0x000003ee0cf1 in password_manager::PasswordManagerBrowserTestBase_InternalsPage_Renderer_Test::RunTestOnMainThread() /usr/local/google/home/vabr/chrome/src/out/asan/../../chrome/browser/password_manager/password_manager_browsertest.cc:2983:12
#15 0x000009d7327c in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() /usr/local/google/home/vabr/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:353:5
#16 0x000008ac48fb in Run /usr/local/google/home/vabr/chrome/src/out/asan/../../base/callback.h:94:12
#17 0x000008ac48fb in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() /usr/local/google/home/vabr/chrome/src/out/asan/../../chrome/browser/chrome_browser_main.cc:1900:0
#18 0x000008ac1a63 in ChromeBrowserMainParts::PreMainMessageLoopRun() /usr/local/google/home/vabr/chrome/src/out/asan/../../chrome/browser/chrome_browser_main.cc:1220:18
#19 0x7f9a134d0ba5 in content::BrowserMainLoop::PreMainMessageLoopRun() /usr/local/google/home/vabr/chrome/src/out/asan/../../content/browser/browser_main_loop.cc:1228:13
#20 0x7f9a1463ad28 in Run /usr/local/google/home/vabr/chrome/src/out/asan/../../base/callback.h:94:12
#21 0x7f9a1463ad28 in content::StartupTaskRunner::RunAllTasksNow() /usr/local/google/home/vabr/chrome/src/out/asan/../../content/browser/startup_task_runner.cc:45:0
#22 0x7f9a134cba67 in content::BrowserMainLoop::CreateStartupTasks() /usr/local/google/home/vabr/chrome/src/out/asan/../../content/browser/browser_main_loop.cc:1012:25
#23 0x7f9a134dc5df in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) /usr/local/google/home/vabr/chrome/src/out/asan/../../content/browser/browser_main_runner.cc:124:17
#24 0x7f9a134c45cd in content::BrowserMain(content::MainFunctionParams const&) /usr/local/google/home/vabr/chrome/src/out/asan/../../content/browser/browser_main.cc:42:32
#25 0x7f9a15c7875c in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) /usr/local/google/home/vabr/chrome/src/out/asan/../../content/app/content_main_runner.cc:421:14
#26 0x7f9a15c7b7ba in content::ContentMainRunnerImpl::Run() /usr/local/google/home/vabr/chrome/src/out/asan/../../content/app/content_main_runner.cc:712:12
#27 0x7f9a0c6944c6 in service_manager::Main(service_manager::MainParams const&) /usr/local/google/home/vabr/chrome/src/out/asan/../../services/service_manager/embedder/main.cc:456:29
#28 0x7f9a15c76935 in content::ContentMain(content::ContentMainParams const&) /usr/local/google/home/vabr/chrome/src/out/asan/../../content/app/content_main.cc:19:10
#29 0x000009d7208c in content::BrowserTestBase::SetUp() /usr/local/google/home/vabr/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:309:3
#30 0x00000894f5ea in InProcessBrowserTest::SetUp() /usr/local/google/home/vabr/chrome/src/out/asan/../../chrome/test/base/in_process_browser_test.cc:263:20
#31 0x000006d10ddd in testing::Test::Run() /usr/local/google/home/vabr/chrome/src/out/asan/../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
#32 0x000006d12e65 in testing::TestInfo::Run() /usr/local/google/home/vabr/chrome/src/out/asan/../../third_party/googletest/src/googletest/src/gtest.cc:2651:11
#33 0x000006d14217 in testing::TestCase::Run() /usr/local/google/home/vabr/chrome/src/out/asan/../../third_party/googletest/src/googletest/src/gtest.cc:2769:28
#34 0x000006d2a317 in testing::internal::UnitTestImpl::RunAllTests() /usr/local/google/home/vabr/chrome/src/out/asan/../../third_party/googletest/src/googletest/src/gtest.cc:4665:43
#35 0x000006d29849 in testing::UnitTest::Run() /usr/local/google/home/vabr/chrome/src/out/asan/../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#36 0x00000898f669 in RUN_ALL_TESTS /usr/local/google/home/vabr/chrome/src/out/asan/../../third_party/googletest/src/googletest/include/gtest/gtest.h:2233:46
#37 0x00000898f669 in base::TestSuite::Run() /usr/local/google/home/vabr/chrome/src/out/asan/../../base/test/test_suite.cc:272:0
#38 0x00000892b5de in ChromeTestSuiteRunner::RunTestSuite(int, char**) /usr/local/google/home/vabr/chrome/src/out/asan/../../chrome/test/base/chrome_test_launcher.cc:72:38
#39 0x000009e8d77f in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) /usr/local/google/home/vabr/chrome/src/out/asan/../../content/public/test/test_launcher.cc:632:31
#40 0x00000892c3c4 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) /usr/local/google/home/vabr/chrome/src/out/asan/../../chrome/test/base/chrome_test_launcher.cc:177:10
#41 0x00000892b39c in main /usr/local/google/home/vabr/chrome/src/out/asan/../../chrome/test/base/browser_tests_main.cc:36:10
#42 0x7f99eeed72b1 in __libc_start_main ??:0:0
#43 0x00000304702a in _start ??:0:0
,
Jan 23 2018
Oh, I just noticed that the failures are test timeouts while waiting for the reload of the page with forms to complete. Will continue looking into why that happens.
,
Jan 23 2018
Removing sheriff label
,
Mar 21 2018
Also times out on Win.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bd199562898f0a98ecc69104101e2b29db95392 commit 2bd199562898f0a98ecc69104101e2b29db95392 Author: Reid Kleckner <rnk@google.com> Date: Wed Mar 21 22:47:39 2018 Disable flaky PasswordManagerBrowserTestBase.InternalsPage_Renderer everywhere This frequently flakes on our Windows Clang ToT bots. TBR=vabr@chromium.org BUG= 804398 Change-Id: I1d67c8de3df9b6868c9444403bd72aae1bc5fade Reviewed-on: https://chromium-review.googlesource.com/974283 Reviewed-by: Reid Kleckner <rnk@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#544886} [modify] https://crrev.com/2bd199562898f0a98ecc69104101e2b29db95392/chrome/browser/password_manager/password_manager_browsertest.cc
,
Mar 22 2018
Detected 4 new flakes for test/step "PasswordManagerBrowserTestBase.InternalsPage_Renderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQAsSBUZsYWtlIjVQYXNzd29yZE1hbmFnZXJCcm93c2VyVGVzdEJhc2UuSW50ZXJuYWxzUGFnZV9SZW5kZXJlcgw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Mar 22 2018
,
Mar 28 2018
Fix in progress at https://crrev.com/c/983353 Flakiness dashboard at https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PasswordManagerBrowserTestBase.InternalsPage_Renderer
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66a3a72586326cc59954c7b7e29ee83b72fcf05f commit 66a3a72586326cc59954c7b7e29ee83b72fcf05f Author: Vaclav Brozek <vabr@chromium.org> Date: Wed Mar 28 11:30:34 2018 Fix PasswordManagerBrowserTestBase.InternalsPage_Renderer The test tries to verify that logging from the renderer process into chrome://password-manager-internals/ works. It does that by opening the internals page and then another tab. Due to race conditions it used to reload the second tab to ensure that messages about availability of logging were passed before logging was due. The test used to timeout, which had to be due to the observer.Wait() call after the reloading. This might have been caused by the waiting condition not being triggered when the reload was initiated too early. The author of the CL admits that he did not understand properly where the issue with Wait() after reload was. However, changing the reload to a navigation to a different page made the Wait() call always succeed, as witnessed by local reproduction of the issue before the change and no more reproduction after it. The reproduction succeeded on a Linux workstation, debug build, with the following command-line: testing/xvfb.py out/gn-dbg/browser_tests \ --gtest_filter='PasswordManagerBrowserTestBase.InternalsPage_Renderer' \ --gtest_repeat=250 \ --gtest_break_on_failure Therefore this CL changes reloading to navigation to a different page and re-enables the test. Bug: 804398 Change-Id: I42fec400dd7d90fb82ff6f318dd05d9ef97e77e1 Reviewed-on: https://chromium-review.googlesource.com/983353 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546456} [modify] https://crrev.com/66a3a72586326cc59954c7b7e29ee83b72fcf05f/chrome/browser/password_manager/password_manager_browsertest.cc
,
Mar 28 2018
,
Mar 29 2018
Just checked the flakiness dashboard (link in #12) and it looks pretty green. :) |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nedngu...@google.com
, Jan 22 2018Status: Assigned (was: Untriaged)