New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804388 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Jan 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Nonetype failure in heuristic analysis

Project Member Reported by lijeffrey@chromium.org, Jan 22 2018 
AttributeError: 'NoneType' object has no attribute 'file'
at _IdentifySuspectedRevisions (/base/data/home/apps/s~findit-for-me/waterfall-backend:13566-065dd65.406871612171608300/waterfall/flake/finish_build_analysis_pipeline.py:138)
at run (/base/data/home/apps/s~findit-for-me/waterfall-backend:13566-065dd65.406871612171608300/waterfall/flake/finish_build_analysis_pipeline.py:202)
at evaluate (/base/data/home/apps/s~findit-for-me/waterfall-backend:13566-065dd65.406871612171608300/infra_api_clients/../third_party/pipeline/pipeline.py:2207)
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7aa15367056ad57fe5471a1dc5cc178a7379e721

commit 7aa15367056ad57fe5471a1dc5cc178a7379e721
Author: Jeffrey Li <lijeffrey@google.com>
Date: Fri Jan 26 21:29:07 2018

[Findit] Flake Analyzer - Fixing Nonetype error in heuristic analysis

It is possible for the test location to be unavailable for some reason.
Flake analysis can still continue without heuristic results, so simply
exclude results if not available and proceed with culprit analysis without
them.

Bug:  804388 

Change-Id: I52c265ecf891c3f86610ffd112996aab377694fd
Reviewed-on: https://chromium-review.googlesource.com/884727
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/7aa15367056ad57fe5471a1dc5cc178a7379e721/appengine/findit/waterfall/flake/finish_build_analysis_pipeline.py
[modify] https://crrev.com/7aa15367056ad57fe5471a1dc5cc178a7379e721/appengine/findit/waterfall/flake/test/finish_build_analysis_pipeline_test.py

Comment 2 by lijeffrey@chromium.org, Jan 26 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment