New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Chrome Home] Remove promo logic

Project Member Reported by mdjones@chromium.org, Jan 22 2018

Issue description

The promo for Chrome Home is no longer needed, so that code and the relevant paths should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eafc9bf42524fc5377bd89ca90f23b6b76f978a0

commit eafc9bf42524fc5377bd89ca90f23b6b76f978a0
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Jan 22 20:52:16 2018

[Home] Remove promo logic and experiments

This change removes all of the logic for the Chrome Home promo.

BUG= 804384 

Change-Id: I1ec00987d94379f45783c0582376a1b52750f81d
Reviewed-on: https://chromium-review.googlesource.com/865824
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530984}
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/drawable-hdpi/ic_new_releases_black_24dp.png
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/drawable-mdpi/ic_new_releases_black_24dp.png
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/drawable-xhdpi/ic_new_releases_black_24dp.png
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/drawable-xxhdpi/ic_new_releases_black_24dp.png
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/drawable-xxxhdpi/ic_new_releases_black_24dp.png
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/drawable/chrome_home_promo_phone_background.xml
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/drawable/chrome_home_promo_static.xml
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/res/layout/chrome_home_promo_header.xml
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/src/org/chromium/chrome/browser/feedback/ChromeHomeFeedbackSource.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomePromoDialog.java
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomePromoIllustration.java
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomePromoMenuHeader.java
[delete] https://crrev.com/c297aad42b62f7f443868da28b21ded199e93996/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomeSnackbarController.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/java_sources.gni
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageUiCaptureTest.java
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/browser/about_flags.cc
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/browser/android/feature_utilities.cc
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/components/ntp_snippets/content_suggestions_service.cc
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/components/ntp_snippets/content_suggestions_service.h
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/components/ntp_snippets/content_suggestions_service_unittest.cc
[modify] https://crrev.com/eafc9bf42524fc5377bd89ca90f23b6b76f978a0/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment