New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804362 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Voice input should not work when a page is recording audio

Project Member Reported by asimjour@chromium.org, Jan 22 2018

Issue description

Voice input button should be disabled when one of the tabs is capturing audio.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e406a0a84c7d5171d41994e6d510a78585fa3e7b

commit e406a0a84c7d5171d41994e6d510a78585fa3e7b
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Mon Jan 22 21:25:28 2018

[VR] Disable voice input when page is capturing audio

Voice input disabled when one of the tabs is capturing autio.

BUG= 804362 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9b80889a93d17bedb16b90c6ef8c3a3ae5e01da8
Reviewed-on: https://chromium-review.googlesource.com/878944
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530998}
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/browser_ui_interface.h
[add] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/model/capturing_state_model.h
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/model/model.h
[delete] https://crrev.com/8ca57e0668cdb054b7e30afd18f9246729764c47/chrome/browser/vr/model/permissions_model.h
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/test/mock_browser_ui_interface.h
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/ui.cc
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/ui.h
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/e406a0a84c7d5171d41994e6d510a78585fa3e7b/chrome/browser/vr/ui_unittest.cc

Status: Fixed (was: Assigned)
Labels: Test-Manual
Labels: Test-Manual
Labels: M-66
Labels: -Test-Manual Test-Complete
Status: Verified (was: Fixed)
Verified on build 66.0.3359.17.
Test case "Voice Input removed while site is recording" added to "VR Browsing: Omnibox text entry manual test plan"

Sign in to add a comment