VR: Make assets component available in tests |
|||||||
Issue descriptionCurrently, all our tests run without the assets component. This is a problem since our performance data is inaccurate and we may also miss other regressions. Thus, use the assets component in tests. To do this we should copy the assets files into the device prior to the test and point the component updater to those files. By doing so, we would skip downloading the assets component, which we are not interested in testing. This also makes the tests more robust. The flow could look like this: - Copy asset files to folder we have write access to. - Start Chrome and let the component updater run. - Point component updater to the files we copied onto the device previously by overriding the paths in https://cs.chromium.org/chromium/src/components/component_updater/component_updater_paths.cc. - Register our assets component. - Component updater should pick up our asset files and make them available to the UI. We can now run tests normally with the assets present.
,
Jan 23 2018
Yeah. But I thought we don't have write access to this folder?
,
Jan 23 2018
We should for Telemetry tests. It's during instrumentation tests that we don't have write access to most things.
,
Jan 23 2018
The component updater work is likely a duplicate of issue 311724. Since there is likely additional work for Android and instrumentation tests, this should probably be blocked on it.
,
Jan 23 2018
Blocking on issue 311724. The steps outlined above are an alternative to a command line argument, which we have a lot of already. Either works for me. And I think it would be good if the solution works for both instrumentation and Telemetry tests.
,
Feb 2 2018
,
Feb 26 2018
,
Mar 1 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ad070f80212fe284cc91a5277b6dd2bb545f7ce4 commit ad070f80212fe284cc91a5277b6dd2bb545f7ce4 Author: bsheedy <bsheedy@google.com> Date: Thu Mar 01 18:58:34 2018
,
Apr 25 2018
,
Jul 4
,
Aug 7
Removing Internals>VR component and assigning to Internals>XR
,
Aug 7
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bsheedy@chromium.org
, Jan 23 2018