New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804326 link

Starred by 3 users
Status: WontFix
Owner:
khushals...@chromium.org
Closed: Jan 2018
Cc:
mlippautz@chromium.org
█ kbr@chromium.org
█ junov@chromium.org
█ pmeenan@chromium.org
█ jlklein@chromium.org
kinuko@chromium.org
█ roc...@chromium.org
peria@chromium.org
ericrk@chromium.org
piman@chromium.org
█ mariakho...@chromium.org
haraken@chromium.org
erikc...@chromium.org
rmcilroy@chromium.org
khushals...@chromium.org
primiano@chromium.org
majidvp@chromium.org
u...@chromium.org
chrishtr@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

22%-312.6% regression in system_health.memory_desktop at 530492:530717

Project Member Reported by pmeenan@chromium.org, Jan 22 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 22 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=804326

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d836f9ba1a3cdc9e00b917366b3d88bdeddc475cbb5513074c18566d3d2ac7bf


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-one
android-webview-nexus5X
android-webview-nexus6
chromium-rel-mac12
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 22 2018 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/16a0c044840000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

Cc: kbr@chromium.org chrishtr@chromium.org mariakho...@chromium.org mlippautz@chromium.org jlklein@chromium.org erikc...@chromium.org junov@chromium.org piman@chromium.org u...@chromium.org haraken@chromium.org khushals...@chromium.org khorimoto@google.com ericrk@chromium.org
Owner: kbr@chromium.org
Status: Assigned (was: Untriaged)
馃搷 Found significant differences after each of 5 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/16a0c044840000

Allow stack-mode for OOP HP to be Finch configurable.
By erikchen@chromium.org 路 Fri Jan 19 19:39:31 2018
chromium @ e113c3b18bffabfd875e3a24a6d6862c0f61e19f

[bindings] Add missing write barrier in DOMDataStore.
By ulan@chromium.org 路 Fri Jan 19 19:44:25 2018
chromium @ 8cfb6c74d5ece32d20f601781a8e8eae002ecd43

blink/canvas: Switch Canvas to use cc's ImageDecodeCache.
By khushalsagar@chromium.org 路 Fri Jan 19 19:47:47 2018
chromium @ 60916ba1169d9207e048e2eca290c946ba37fcad

[CrOS Tether] Increase timeout for receiving ConnectTetheringResponse.
By khorimoto@google.com 路 Fri Jan 19 20:42:44 2018
chromium @ b4adc605cf848a97561924ada89cab404ecbdab0

Re-enable a GPU unittest and update it for the new browser creation API.
By kbr@chromium.org 路 Fri Jan 19 21:06:40 2018
chromium @ 2922c9017fcd63c0a738fff449731b05f9f66419

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by kbr@chromium.org, Jan 23 2018

Owner: ----
Status: Available (was: Assigned)
It's definitely not my patch.

Comment 5 by khorimoto@chromium.org, Jan 23 2018

Cc: -khorimoto@google.com

Comment 6 by chrishtr@chromium.org, Jan 23 2018

Components: Blink>Canvas
Owner: khushals...@chromium.org
Status: Assigned (was: Available)

Comment 7 by khushals...@chromium.org, Jan 23 2018 

There are regressions reported from cc:effective_size_avg, which are expected since canvas switches to using cc's decode caching. As a result, what used to reported in skia is now reported in cc [1].

The v8 heap changes don't look related. I'll start another bisect for those.

[1]: https://chromeperf.appspot.com/report?sid=2f20f02cada0d6439e620e58b5f58cfc35aff69a6b80d30ae9c31a31db62dde3
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jan 23 2018 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14b021f4840000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jan 24 2018

Cc: kinuko@chromium.org peria@chromium.org rmcilroy@chromium.org roc...@chromium.org
Owner: peria@chromium.org
馃搷 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14b021f4840000

gin: Make v8_context_snapshot.bin as a default snapshot blob
By peria@chromium.org 路 Fri Jan 19 16:55:03 2018
chromium @ 9aff02e57fa82b584e238390f1739ff410dfd377

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 11 by peria@chromium.org, Jan 24 2018

Components: Blink>Bindings
Labels: OS-Mac
Status: Started (was: Assigned)
my change could regress memory usages on desktop, but the number seems too large.
Dropped regressions on android, and start running a bisect.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jan 24 2018

Owner: khushals...@chromium.org
Status: Assigned (was: Started)
馃搷 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11a68d34840000

blink/canvas: Switch Canvas to use cc's ImageDecodeCache.
By khushalsagar@chromium.org 路 Fri Jan 19 19:47:47 2018
chromium @ 60916ba1169d9207e048e2eca290c946ba37fcad

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 13 by khushals...@chromium.org, Jan 24 2018

Status: WontFix (was: Assigned)
peria@, sorry for being a bit unclear there. The cc::effective_size_avg alerts are not actionable, they are expected from the change in #12. I've moved the v8 ones to  issue 805559 . Closing this issue.

Comment 15 by khushals...@chromium.org, Jan 26 2018

Cc: majidvp@chromium.org
 Issue 805587  has been merged into this issue.

Comment 16 by khushals...@chromium.org, Jan 30 2018

Cc: primiano@chromium.org
 Issue 806820  has been merged into this issue.

Comment 17 by khushals...@chromium.org, Jan 30 2018 

 Issue 806819  has been merged into this issue.
►

Sign in to add a comment