i915: External monitor flashes when hdcp is enabled/disabled |
|||||||
Issue descriptionBecause HDCP requires a modeset to toggle on i915, the screen will flash when protected content is started/stopped. Sad!
,
Jan 22 2018
,
Jan 23 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/337b03293334f91ca722eaa2b6669956453852de commit 337b03293334f91ca722eaa2b6669956453852de Author: Sean Paul <seanpaul@chromium.org> Date: Wed Jan 24 01:41:59 2018 CHROMIUM: drm/i915: Don't modeset to toggle hdcp This patch moves the hdcp enable/disable to atomic commit instead of requiring a modeset. The result is a much better user experience since the monitor doesn't flash everytime playback is initiated/stopped. Upstream didn't like the added complexity of adding yet another thing in commit_tail, so we'll keep this local for now. Hopefully once we upstream the rockchip implementation (which shares some of this code), we can move i915 along too. BUG= 804309 TEST=Tested on fizz, played protected content observed no flashes Change-Id: Ia25119652b2cd9bc666a3670d04649e1d5fbc28a Signed-off-by: Sean Paul <seanpaul@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/874852 Commit-Ready: Sean Paul <seanpaul@google.com> Tested-by: Sean Paul <seanpaul@google.com> Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> [modify] https://crrev.com/337b03293334f91ca722eaa2b6669956453852de/drivers/gpu/drm/i915/intel_display.c [modify] https://crrev.com/337b03293334f91ca722eaa2b6669956453852de/drivers/gpu/drm/i915/intel_ddi.c [modify] https://crrev.com/337b03293334f91ca722eaa2b6669956453852de/drivers/gpu/drm/i915/intel_hdcp.c
,
Jan 24 2018
,
Jan 24 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/66fc53282694f59203287eba4d4ffed95d513775 commit 66fc53282694f59203287eba4d4ffed95d513775 Author: Sean Paul <seanpaul@chromium.org> Date: Wed Jan 24 19:01:18 2018 CHROMIUM: drm/i915: Don't modeset to toggle hdcp This patch moves the hdcp enable/disable to atomic commit instead of requiring a modeset. The result is a much better user experience since the monitor doesn't flash everytime playback is initiated/stopped. Upstream didn't like the added complexity of adding yet another thing in commit_tail, so we'll keep this local for now. Hopefully once we upstream the rockchip implementation (which shares some of this code), we can move i915 along too. BUG= 804309 TEST=Tested on fizz, played protected content observed no flashes Change-Id: Ia25119652b2cd9bc666a3670d04649e1d5fbc28a Signed-off-by: Sean Paul <seanpaul@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/881603 Reviewed-by: Sean Paul <seanpaul@google.com> Commit-Queue: Sean Paul <seanpaul@google.com> Tested-by: Sean Paul <seanpaul@google.com> [modify] https://crrev.com/66fc53282694f59203287eba4d4ffed95d513775/drivers/gpu/drm/i915/intel_display.c [modify] https://crrev.com/66fc53282694f59203287eba4d4ffed95d513775/drivers/gpu/drm/i915/intel_ddi.c [modify] https://crrev.com/66fc53282694f59203287eba4d4ffed95d513775/drivers/gpu/drm/i915/intel_hdcp.c
,
Feb 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by seanpaul@chromium.org
, Jan 22 2018