"Ignoring invalid file v8_context_snapshot.bin" in builds without the context snapshot |
||
Issue descriptionBuilds that explicitly set use_v8_context_snapshot=false, or Linux builds that are not using that by default, print a warning log to console on each startup. That's unhelpful, it would be better to not try loading a file we won't have. [25098:25128:1019/160557.197032:2678310968639:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f59c7dc8dfb1917a87124c149aa2cffea002ef9 commit 6f59c7dc8dfb1917a87124c149aa2cffea002ef9 Author: tsniatowski@opera.com <tsniatowski@vewd.com> Date: Fri Jan 26 23:30:18 2018 Avoid loading v8_context_snapshot.bin if it's disabled at build-time Don't list the context snapshot in the mojo manifest's required_files in builds with use_v8_context_snapshot=false. Tweak existing manifest overlay functionality to allow merging of required_files lists from multiple manifests. This avoids an "Ignoring invalid file v8_context_snapshot.bin" warning on each browser stratup in use_v8_context_snapshot=false builds. Bug: 804293 Change-Id: I0f4731811044980b7466887bedcaf115ee1fb288 Reviewed-on: https://chromium-review.googlesource.com/878371 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#532088} [modify] https://crrev.com/6f59c7dc8dfb1917a87124c149aa2cffea002ef9/content/public/app/BUILD.gn [modify] https://crrev.com/6f59c7dc8dfb1917a87124c149aa2cffea002ef9/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/6f59c7dc8dfb1917a87124c149aa2cffea002ef9/content/public/app/mojo/content_utility_manifest.json [add] https://crrev.com/6f59c7dc8dfb1917a87124c149aa2cffea002ef9/content/public/app/mojo/context_snapshot_manifest.json [modify] https://crrev.com/6f59c7dc8dfb1917a87124c149aa2cffea002ef9/services/service_manager/public/service_manifest.gni [modify] https://crrev.com/6f59c7dc8dfb1917a87124c149aa2cffea002ef9/services/service_manager/public/tools/manifest/manifest_collator.py
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecbeaa90df3261ec229e919619d526bc021b2eec commit ecbeaa90df3261ec229e919619d526bc021b2eec Author: Hitoshi Yoshida <peria@chromium.org> Date: Mon Feb 05 00:44:33 2018 Add loading snapshot_blob.bin if v8_context_snapshot is disabled Even if we add use_v8_context_snapshot=false, we still need snapshot_blob.bin instead of v8_context_snapshot.bin for performance. This is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/878371 Bug: 804293 Change-Id: Id0af5b120993964401beaf559c2e4b5ff9b7c6dd Reviewed-on: https://chromium-review.googlesource.com/897082 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#534311} [modify] https://crrev.com/ecbeaa90df3261ec229e919619d526bc021b2eec/content/public/app/BUILD.gn [add] https://crrev.com/ecbeaa90df3261ec229e919619d526bc021b2eec/content/public/app/mojo/snapshot_blob_manifest.json
,
Feb 6 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by adithyas@chromium.org
, Jan 26 2018