Add ScrollAnchorSerialization to chrome://flags |
|||||||
Issue descriptionSo that it can be enabled via a Finch experiment
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ee016ec326cfe6d28084200695d8c6c6e2024b5 commit 8ee016ec326cfe6d28084200695d8c6c6e2024b5 Author: Patrick Noland <pnoland@google.com> Date: Wed Jan 24 11:44:53 2018 Add about://flags entry for scroll anchor serialization Also fixes a crash encountered when enabling the flag for the first time. R: skobes@chromium.org, jochen@chromium.org Bug: 804281 Change-Id: Ie857f49cad146aac1fa20e77c13a697f06fa47b0 Reviewed-on: https://chromium-review.googlesource.com/878721 Commit-Queue: Patrick Noland <pnoland@google.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#531501} [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/chrome/browser/about_flags.cc [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/chrome/browser/flag_descriptions.h [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/content/child/runtime_features.cc [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/content/public/common/content_features.cc [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/content/public/common/content_features.h [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/third_party/WebKit/public/platform/WebRuntimeFeatures.h [modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/tools/metrics/histograms/enums.xml
,
Jan 24 2018
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
Tested the issue on Mac 10.13.3, Windows 10 and Ubuntu 14.04 using Chrome version M66 - 66.0.3331.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Able to enable the flag #enable-scroll-anchor-serialization in chrome://flags and relaunch the Chrome without any crash). Hence adding TE-Verified label. Attached the screencast for reference.
,
Jan 25 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b41cf04751ef011db52232e3ff365fe63e415583 commit b41cf04751ef011db52232e3ff365fe63e415583 Author: Patrick Noland <pnoland@google.com> Date: Thu Jan 25 17:00:35 2018 Add about://flags entry for scroll anchor serialization Also fixes a crash encountered when enabling the flag for the first time. R: skobes@chromium.org, jochen@chromium.org Bug: 804281 Change-Id: Ie857f49cad146aac1fa20e77c13a697f06fa47b0 Reviewed-on: https://chromium-review.googlesource.com/878721 Commit-Queue: Patrick Noland <pnoland@google.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531501}(cherry picked from commit 8ee016ec326cfe6d28084200695d8c6c6e2024b5) Reviewed-on: https://chromium-review.googlesource.com/887141 Reviewed-by: Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/branch-heads/3325@{#91} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/chrome/browser/about_flags.cc [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/chrome/browser/flag_descriptions.h [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/content/child/runtime_features.cc [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/content/public/common/content_features.cc [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/content/public/common/content_features.h [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/third_party/WebKit/public/platform/WebRuntimeFeatures.h [modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/tools/metrics/histograms/enums.xml
,
Jan 30 2018
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using Chrome dev version #65.0.3325.31 as per the comment #0 and issue description. Attaching screen cast for reference. Observed that ScrollAnchorSerialization is added to chrome://flags. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Feb 2 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pnoland@chromium.org
, Jan 22 2018