New issue
Advanced search Search tips

Issue 804281 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task



Sign in to add a comment

Add ScrollAnchorSerialization to chrome://flags

Project Member Reported by pnoland@chromium.org, Jan 22 2018

Issue description

So that it can be enabled via a Finch experiment
 
Cc: ew...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee016ec326cfe6d28084200695d8c6c6e2024b5

commit 8ee016ec326cfe6d28084200695d8c6c6e2024b5
Author: Patrick Noland <pnoland@google.com>
Date: Wed Jan 24 11:44:53 2018

Add about://flags entry for scroll anchor serialization

Also fixes a crash encountered when enabling the flag for the first
time.

R: skobes@chromium.org, jochen@chromium.org
Bug:  804281 
Change-Id: Ie857f49cad146aac1fa20e77c13a697f06fa47b0
Reviewed-on: https://chromium-review.googlesource.com/878721
Commit-Queue: Patrick Noland <pnoland@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531501}
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/chrome/browser/about_flags.cc
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/content/child/runtime_features.cc
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/content/public/common/content_features.cc
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/content/public/common/content_features.h
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/8ee016ec326cfe6d28084200695d8c6c6e2024b5/tools/metrics/histograms/enums.xml

Labels: Merge-Request-65 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: pnangunoori@chromium.org
Labels: TE-Verified-66.0.3331.0 TE-Verified-M66
Tested the issue on Mac 10.13.3, Windows 10 and Ubuntu 14.04 using Chrome version M66 - 66.0.3331.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Able to enable the flag #enable-scroll-anchor-serialization in chrome://flags and relaunch the Chrome without any crash). Hence adding TE-Verified label. Attached the screencast for reference.

804281.webm
4.1 MB View Download

Comment 6 by gov...@chromium.org, Jan 25 2018

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 25 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b41cf04751ef011db52232e3ff365fe63e415583

commit b41cf04751ef011db52232e3ff365fe63e415583
Author: Patrick Noland <pnoland@google.com>
Date: Thu Jan 25 17:00:35 2018

Add about://flags entry for scroll anchor serialization

Also fixes a crash encountered when enabling the flag for the first
time.

R: skobes@chromium.org, jochen@chromium.org
Bug:  804281 
Change-Id: Ie857f49cad146aac1fa20e77c13a697f06fa47b0
Reviewed-on: https://chromium-review.googlesource.com/878721
Commit-Queue: Patrick Noland <pnoland@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531501}(cherry picked from commit 8ee016ec326cfe6d28084200695d8c6c6e2024b5)
Reviewed-on: https://chromium-review.googlesource.com/887141
Reviewed-by: Patrick Noland <pnoland@google.com>
Cr-Commit-Position: refs/branch-heads/3325@{#91}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/chrome/browser/about_flags.cc
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/content/child/runtime_features.cc
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/content/public/common/content_features.cc
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/content/public/common/content_features.h
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/b41cf04751ef011db52232e3ff365fe63e415583/tools/metrics/histograms/enums.xml

Labels: TE-Verified-M65 TE-Verified-65.0.3325.31
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using Chrome dev version #65.0.3325.31 as per the comment #0 and issue description.
Attaching screen cast for reference.
Observed that ScrollAnchorSerialization is added to chrome://flags.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
804281.mp4
1.1 MB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment