New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804274 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to connect to network in 'Join Wi-Fi network' overlay using 'Enter' button from Keyboard

Project Member Reported by mmanchala@chromium.org, Jan 22 2018

Issue description

Chrome Version: 66.0.3327.0/10330.0.0 dev channel Kip, Daisy,Reks
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network ->'Join Wi-Fi network' overlay is seen and enter correct password  -> Now press 'Enter' button from keyboard and observe it is not working 
(Please refer video and Screenshot)

Expected: On clicking 'Enter' button from keyboard 'Join Wi-Fi network' overlay should get close and Network should get connected 
Actual: Instead network is not getting connected  On clicking 'Enter' button from keyboard  i.e. 'Join Wi-Fi network' overlay is still seen

This is Regression Issue as same is working fine in 65.0.3294.0/10216.0.0 dev-channel Reks and issue is not working fine on M-65 latest build 65.0.3325.0/10323.0.0 dev-channel Reks

@stevenjb : Please confirm the Issue

Note : Issue is working fine in M-63 Stable and M-64 Beta 
 
Actual_EnterButtonNotWorking.mp4
10.7 MB View Download
Expected_EnterButton.mp4
11.4 MB View Download
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22d95118a5b26a55b2b09535d9363170ef4a9dc7

commit 22d95118a5b26a55b2b09535d9363170ef4a9dc7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 23 17:04:24 2018

Network config: Connect on password enter if configured

Bug:  804274 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e09fab83d79f70545e222c1ca468171264e5e67
Reviewed-on: https://chromium-review.googlesource.com/879230
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531263}
[modify] https://crrev.com/22d95118a5b26a55b2b09535d9363170ef4a9dc7/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/22d95118a5b26a55b2b09535d9363170ef4a9dc7/ui/webui/resources/cr_components/chromeos/network/network_config.js

Status: Fixed (was: Started)
Labels: Merge-Request-65
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 24 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2f42bab990f21424d2dc3c398aeaa1ae6459bfb

commit b2f42bab990f21424d2dc3c398aeaa1ae6459bfb
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 24 18:26:23 2018

Network config: Connect on password enter if configured

TBR=stevenjb@chromium.org

(cherry picked from commit 22d95118a5b26a55b2b09535d9363170ef4a9dc7)

Bug:  804274 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e09fab83d79f70545e222c1ca468171264e5e67
Reviewed-on: https://chromium-review.googlesource.com/879230
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531263}
Reviewed-on: https://chromium-review.googlesource.com/883906
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#66}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/b2f42bab990f21424d2dc3c398aeaa1ae6459bfb/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/b2f42bab990f21424d2dc3c398aeaa1ae6459bfb/ui/webui/resources/cr_components/chromeos/network/network_config.js

Labels: Inhouse-HYD-Reported
Cc: steve...@chromium.org
 Issue 808895  has been merged into this issue.

Sign in to add a comment