New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804273 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Regression : Video is not playing automatically in General information page

Project Member Reported by mmanchala@chromium.org, Jan 22 2018

Issue description

Chrome Version: 66.0.3327.0/10330.0.0 dev channel Kip, Daisy,Reks
OS: Chrome

Sample URL : http://www.sample-videos.com/

What steps will reproduce the problem?
(1)Sign in to user ->Now go to above URL -> download any file
(2)Now go to Files App  -> Select downloaded video -> Right Click and select 'Get info' option or click on 'Space' Key
(3)After clicking on 'Get info' option or on 'Space' Key observe Video will not start playing automatically in General information page 
(Please refer video)

Expected: Video should start playing automatically after clicking on 'Get info' option or on 'Space' Key 
Actual: Instead Video is not playing automatically in General information page  

This is Regression Issue seen as same is working fine in 65.0.3299.0/10253.0.0 dev-channel Reks and issue is not working fine on M-65 latest build 65.0.3325.0/10323.0.0 dev-channel Reks

@fukino : Please confirm the Issue

Note : Issue is working fine in M-63 Stable and M-64 Beta 
 
Actual_Video.webm
804 KB View Download
Expected_Video.webm
2.9 MB View Download

Comment 1 by fukino@chromium.org, Jan 30 2018

Cc: hanxi@chromium.org lfg@chromium.org
Now that autoplay policy has changed, the autoplay function in quick view has stopped working.
https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

To preview video files in Files app's quick view, we use <video> tag with "autoplay" attribute.
(i.e. <video autoplay src=...>)
For security reason, we load a document containing the video tag inside <webview> tag. It seems the policy change affect the video tag inside <webview>.

+hanxi@, lfg@ from components/guest_view OWNERS.
Is there a way to enable autoplay in <webview>?

According to https://developers.google.com/web/updates/2017/09/autoplay-policy-changes#iframe, we can delegate autoplay permission to our iframes to allow autoplay.
But I'm not sure if we have similar options on <webview>.
Labels: Inhouse-HYD-Reported
Given the policy update - let's proceed with enabling muted auto-play for M65.

Comment 4 by hanxi@chromium.org, Feb 7 2018

Cc: wjmaclean@chromium.org paulmeyer@chromium.org
I am no longer working on gurest_view, +paulmeyer@ and wjmaclean@ for opinions.
Labels: -Type-Bug-Regression Type-Feature
If this is due to a purposeful policy change, I don't think it should be labelled as a regression. Since this bug is turning into a feature request, let's relabel it as such.
Components: Blink>Media>Autoplay

Comment 7 by fukino@chromium.org, Feb 15 2018

Status: Started (was: Assigned)
For M65, we are going with muted autoplay for video preview function.
After a patch for muted autoplay lands, I'll keep this bug open as a feature request to enable unmuted autoplay by delegating permission to the iframe in <webview>.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33e085fe31cc14110fc52092a35ee84c412b6bbb

commit 33e085fe31cc14110fc52092a35ee84c412b6bbb
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Feb 15 09:57:21 2018

Files app: Enable muted autoplay for previewing video files.

Due to a Chrome policy change, autoplaying videos does not work in quick view.
Instead, we introduce muted autoplay to help users preview video files.

Bug: 804273
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I07768b04ff3994f53811d22fd33613291dd5b896
Reviewed-on: https://chromium-review.googlesource.com/920049
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536980}
[modify] https://crrev.com/33e085fe31cc14110fc52092a35ee84c412b6bbb/ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.html

Comment 9 by fukino@chromium.org, Feb 15 2018

Labels: Merge-Request-65
I'd like to merge the patch in comment #8 to M65.

This issue will be perceived as a regression from users.
The fix in comment #8 mitigate the issue, with extremely low risk.
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 16 2018

Labels: -Merge-Request-65 Merge-Reject-65 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M65 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Feature -Merge-Reject-65 Merge-Request-65 Type-Bug-Regression
It is actually a regression from the users' standpoint.
Let me get the type back to Regression and re-request a merge.

Once the mitigation in comment #8 is merged, I'll change the issue type to Feature to pursuit further improvement.
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 16 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Hotlist-Merge-Reject -Merge-Review-65 Merge-Approved-65
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 21 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ac90930492bd8b71f56796f78c63e21faf7e45e

commit 4ac90930492bd8b71f56796f78c63e21faf7e45e
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Feb 21 09:03:17 2018

Files app: Enable muted autoplay for previewing video files.

Due to a Chrome policy change, autoplaying videos does not work in quick view.
Instead, we introduce muted autoplay to help users preview video files.

Bug: 804273
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I07768b04ff3994f53811d22fd33613291dd5b896
Reviewed-on: https://chromium-review.googlesource.com/920049
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536980}(cherry picked from commit 33e085fe31cc14110fc52092a35ee84c412b6bbb)
Reviewed-on: https://chromium-review.googlesource.com/928062
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#528}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/4ac90930492bd8b71f56796f78c63e21faf7e45e/ui/file_manager/file_manager/foreground/elements/files_safe_video_webview_content.html

Cc: slangley@chromium.org sashab@chromium.org joelhockey@chromium.org weifangsun@chromium.org fukino@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable -Type-Bug-Regression -M-65 Pri-3 Type-Feature
Owner: ----
Status: Untriaged (was: Started)
The mitigation (introducing muted autoplay for videos) has landed.

Changing the bug type as a Feature to re-enable the autoplay with sound in quick view.
Let me release this bug to find another owner for the improvement.
Status: Available (was: Untriaged)
Labels: CrOS-FilesApp-QuickView
Labels: -CrOS-FilesApp-QuickView CrOSFilesFeature-QuickView
Components: -Blink>Media>Autoplay
Removing Blink>Media>Autoplay, please re-add if there's an issue with the policy
Owner: weifangsun@chromium.org
Status: Assigned (was: Available)
Weifang - please advise on the priority for this? :)
Owner: ----
Status: Available (was: Assigned)
We can keep this as a P3 for now and revisit when we are looking to clean up/improve Quick View.

Sign in to add a comment