New issue
Advanced search Search tips

Issue 804270 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3 sometimes fails to cancel echoes during the first seconds in a call

Project Member Reported by peah@chromium.org, Jan 22 2018

Issue description

Depending on how the call is made, AEC3 may fail to cancel parts of the echoes present in the first seconds of a call. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/0eef9c0c61fef66bceb6767ad2db83cd8c60b409

commit 0eef9c0c61fef66bceb6767ad2db83cd8c60b409
Author: Per Åhgren <peah@webrtc.org>
Date: Mon Jan 22 20:50:39 2018

Increasing the speed of the initial alignment in AEC3

This CL increases the speech of the initial alignment in AEC3 by
loosening the requirements on the accuracy of the initial estimates.

Bug:  webrtc:8784 ,  chromium:804270 
Change-Id: I86e2d97830843524090a1cf877965739f66dc058
Reviewed-on: https://webrtc-review.googlesource.com/40660
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21728}
[modify] https://crrev.com/0eef9c0c61fef66bceb6767ad2db83cd8c60b409/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/0eef9c0c61fef66bceb6767ad2db83cd8c60b409/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc
[modify] https://crrev.com/0eef9c0c61fef66bceb6767ad2db83cd8c60b409/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc
[modify] https://crrev.com/0eef9c0c61fef66bceb6767ad2db83cd8c60b409/modules/audio_processing/aec3/matched_filter_lag_aggregator.h
[modify] https://crrev.com/0eef9c0c61fef66bceb6767ad2db83cd8c60b409/modules/audio_processing/aec3/matched_filter_lag_aggregator_unittest.cc
[modify] https://crrev.com/0eef9c0c61fef66bceb6767ad2db83cd8c60b409/modules/audio_processing/aec3/render_delay_controller.cc

Comment 2 by peah@chromium.org, Feb 6 2018

Labels: -Pri-2 Merge-Request-65 Pri-1
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 7 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 Beta release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2018

Labels: merge-merged-65
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/df63672c0050ff6706f7d83ca7252ae29f46f8b7

commit df63672c0050ff6706f7d83ca7252ae29f46f8b7
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Feb 07 19:29:18 2018

Merge of Increasing the speed of the initial alignment in AEC3

This CL increases the speech of the initial alignment in AEC3 by
loosening the requirements on the accuracy of the initial estimates.

TBR=henrik.lundin@webrtc.org,gustaf@webrtc.org
(cherry picked from commit 0eef9c0c61fef66bceb6767ad2db83cd8c60b409)

Bug:  webrtc:8784 ,  chromium:804270 
Change-Id: I86e2d97830843524090a1cf877965739f66dc058
Reviewed-on: https://webrtc-review.googlesource.com/40660
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#21728}
Reviewed-on: https://webrtc-review.googlesource.com/49440
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/65@{#11}
Cr-Branched-From: 3ac67a736bb200ecf7c116a88b2f8d5c542973c8-refs/heads/master@{#21637}
[modify] https://crrev.com/df63672c0050ff6706f7d83ca7252ae29f46f8b7/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/df63672c0050ff6706f7d83ca7252ae29f46f8b7/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc
[modify] https://crrev.com/df63672c0050ff6706f7d83ca7252ae29f46f8b7/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc
[modify] https://crrev.com/df63672c0050ff6706f7d83ca7252ae29f46f8b7/modules/audio_processing/aec3/matched_filter_lag_aggregator.h
[modify] https://crrev.com/df63672c0050ff6706f7d83ca7252ae29f46f8b7/modules/audio_processing/aec3/matched_filter_lag_aggregator_unittest.cc
[modify] https://crrev.com/df63672c0050ff6706f7d83ca7252ae29f46f8b7/modules/audio_processing/aec3/render_delay_controller.cc

Labels: -Merge-Approved-65
This is already merged to M65 at #5. Hence, removing "Merge-Approved-65" label.

Comment 7 by peah@chromium.org, Feb 7 2018

Status: Fixed (was: Assigned)

Comment 8 by peah@chromium.org, Feb 7 2018

Labels: M-65

Sign in to add a comment