New issue
Advanced search Search tips

Issue 804267 link

Starred by 1 user
Status: Fixed
Owner:
peah@chromium.org
Closed: Jan 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The look window in AEC3 for the nonlinear mode was shortened too much

Project Member Reported by peah@chromium.org, Jan 22 2018 
During code refactoring, the size of the look window for the nonlinear mode in AEC3 became too short. This causes echo leakage.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/395791fea76c1626aeb3d04cb86086d7c01c87d9

commit 395791fea76c1626aeb3d04cb86086d7c01c87d9
Author: Per Åhgren <peah@webrtc.org>
Date: Mon Jan 22 16:36:38 2018

Length-correction of the look window used during nonlinear echo removal

Bug:  webrtc:8783 , chromium:804267 
Change-Id: Ib05a28112fe53c2d510ae1bafd05e535fdf35214
Reviewed-on: https://webrtc-review.googlesource.com/42582
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21724}
[modify] https://crrev.com/395791fea76c1626aeb3d04cb86086d7c01c87d9/modules/audio_processing/aec3/residual_echo_estimator.cc

Comment 2 by peah@chromium.org, Jan 23 2018

Labels: -Pri-2 Merge-Request-65 Pri-1
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 24 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Jan 24 2018 

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next dev release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 25 2018

Labels: merge-merged-65
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/15cba4391c10d5ce16aac067c5d50e938f5438d0

commit 15cba4391c10d5ce16aac067c5d50e938f5438d0
Author: Per Åhgren <peah@webrtc.org>
Date: Thu Jan 25 07:49:22 2018

Merge of Length-correction of the look window used during nonlinear

TBR=gustaf@webrtc.org,henrik.lundin@webrt.org

(cherry picked from commit 395791fea76c1626aeb3d04cb86086d7c01c87d9)

Bug:  webrtc:8783 , chromium:804267 
Change-Id: Ib05a28112fe53c2d510ae1bafd05e535fdf35214
Reviewed-on: https://webrtc-review.googlesource.com/42582
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#21724}
Reviewed-on: https://webrtc-review.googlesource.com/43700
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/65@{#4}
Cr-Branched-From: 3ac67a736bb200ecf7c116a88b2f8d5c542973c8-refs/heads/master@{#21637}
[modify] https://crrev.com/15cba4391c10d5ce16aac067c5d50e938f5438d0/modules/audio_processing/aec3/residual_echo_estimator.cc

Comment 6 by peah@chromium.org, Jan 25 2018

Labels: M-65
Status: Fixed (was: Assigned)

Comment 7 by gov...@chromium.org, Jan 25 2018

Labels: -Merge-Approved-65
Per comment #5, this is already merged to M65.
►

Sign in to add a comment