Issue metadata
Sign in to add a comment
|
Regression:Favicon fades on changing the permission settings on view page info bubble.
Reported by
shruti.j...@etouch.net,
Jan 22 2018
|
||||||||||||||||||||||||
Issue description
Chrome Version: 66.0.3328.0 (Official Build) Revision1629a284e7c7c2ea5e562d9f242a84992cab5ed7-refs/heads/master@{#530801}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.3)
Steps to reproduce:
(1) Launch chrome, navigate to www.google.com and click on Security chip.
(2) Change 'Flash' settings to 'Allow' and observe.
Actual Result: Favicon fades on changing the permission settings on view page info bubble.
Expected Result: Favicon should not get fade on changing the permission settings on view page info bubble.
This is a regression issue broken in ‘M-65’ and using per-revision bisect providing the bisect results,
Good Build:65.0.3324.0(Revision:530028)
Bad Build:65.0.3325.0(Revision:530369)
You are probably looking for a change made after 530029 (known good), but no later than 530031 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/037ff9cb5f10325a98cf43822655d532a8286f5f..c408bd3061c9e33e1ab0cf880bf4bbda6948381d
Suspect:https://chromium.googlesource.com/chromium/src/+/c408bd3061c9e33e1ab0cf880bf4bbda6948381d
@patricialor: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Kindly review the attached screen-cast and screen-shots for the reference.
Thank You!
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/670de664b3b363f810b2eecd144ea470b9d9f086 commit 670de664b3b363f810b2eecd144ea470b9d9f086 Author: Patti <patricialor@chromium.org> Date: Tue Jan 23 01:52:15 2018 Desktop Page Info/Views: Fix icon getting the wrong color on permission changes. An extra call to color_utils::DeriveDefaultIconColor() was causing the icon color to change to one that was too light after a permission is changed via the Page Info bubble. Fix by removing it. Bug: 804264 Change-Id: If2f791f0df182c7e698f0e8fd0db04cf58b18147 Reviewed-on: https://chromium-review.googlesource.com/879641 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#531124} [modify] https://crrev.com/670de664b3b363f810b2eecd144ea470b9d9f086/chrome/browser/ui/views/page_info/permission_selector_row.cc
,
Jan 23 2018
Thank you for finding this! It should be fixed now.
,
Jan 23 2018
Rechecked the above issue on OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.3) with latest canary chrome version: 66.0.3329.0 and the issue works as intended. Kindly refer attached screen cast for reference.
,
Feb 2 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by shruti.j...@etouch.net
, Jan 22 2018